From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14347 invoked by alias); 18 Nov 2011 14:14:04 -0000 Received: (qmail 14336 invoked by uid 22791); 18 Nov 2011 14:14:03 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_40,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Nov 2011 14:13:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 330572BB132; Fri, 18 Nov 2011 09:13:42 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KvIU89gnh7H4; Fri, 18 Nov 2011 09:13:42 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1E2022BB12E; Fri, 18 Nov 2011 09:13:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 98DFD145615; Fri, 18 Nov 2011 09:13:40 -0500 (EST) Date: Fri, 18 Nov 2011 14:14:00 -0000 From: Joel Brobecker To: Andrey Smirnov Cc: gdb-patches Subject: Re: [PATCH 1/348] Fix -Wshadow errors Message-ID: <20111118141340.GC2703@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00498.txt.bz2 Andrey, > --- > gdb/ada-exp.y | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) This change is OK, but we need a ChangeLog entry for it. As soon as you've resubmitted it with the ChangeLog entry, we can give you write access to the GDB repository, and you'll be able to commit the approved patches yourself. If you haven't already done so, please read the gdb/CONTRIBUTE file... Generally speaking, we also expect all changes to be validated against our testsuite. This means running the testsuite before and after the patch, and making sure that new failures did not appear in the meantime. > > diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y > index 9576be5..bfa3913 100644 > --- a/gdb/ada-exp.y > +++ b/gdb/ada-exp.y > @@ -1287,12 +1287,12 @@ write_var_or_type (struct block *block, struct stoken name0) > FIXME pnh 7/20/2007. */ > if (nsyms == 1) > { > - struct symbol *renaming = > + struct symbol *ren_sym = > ada_find_renaming_symbol (SYMBOL_LINKAGE_NAME (syms[0].sym), > syms[0].block); > > - if (renaming != NULL) > - syms[0].sym = renaming; > + if (ren_sym != NULL) > + syms[0].sym = ren_sym; > } > > type_sym = select_possible_type_sym (syms, nsyms); > -- > 1.7.5.4 > -- Joel