Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Kargov <kargov@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix the x87 FP register printout by “info float”.
Date: Fri, 19 Apr 2013 18:23:00 -0000	[thread overview]
Message-ID: <CAHLdKi=tC-19SW9AOim1nm-ZhnrN6WqQmv_yEZvM2ehLNEPjEA@mail.gmail.com> (raw)
In-Reply-To: <517153B4.1060605@redhat.com>

On 19 April 2013 18:24, Pedro Alves <palves@redhat.com> wrote:
> I believe printing a negative value with an unsigned format
> specifier is actually undefined.
I've just checked C99 and yes, it appears to be undefined after all (I
actually thought that the C standard mandated a uniform representation
of negative integer numbers which it didn't!), so my patch indeed
exploited compiler and hardware dependent behaviour.

> I'm applying the patch
> I'll just point out what needed fixing, FYI.
Thanks, and thank you for the review!

-- 
Vladimir


      reply	other threads:[~2013-04-19 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 15:40 Vladimir Kargov
2013-04-19  9:43 ` Pedro Alves
2013-04-19 14:30   ` Vladimir Kargov
2013-04-19 14:33     ` Pedro Alves
2013-04-19 18:23       ` Vladimir Kargov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLdKi=tC-19SW9AOim1nm-ZhnrN6WqQmv_yEZvM2ehLNEPjEA@mail.gmail.com' \
    --to=kargov@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox