From: Pedro Alves <palves@redhat.com>
To: Vladimir Kargov <kargov@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix the x87 FP register printout by “info float”.
Date: Fri, 19 Apr 2013 09:43:00 -0000 [thread overview]
Message-ID: <516FC7B3.4050502@redhat.com> (raw)
In-Reply-To: <CAHLdKi=qPX-x7Eb0gwqTaOsWp0gK0=3WQFLmc6_HBKGUZ7RzfQ@mail.gmail.com>
On 04/18/2013 01:51 AM, Vladimir Kargov wrote:
> Another way to fix this would be to replace the type in the definition
> of variable "raw" from "char" to "gdb_char" which is currently defined
> as "unsigned char",
You must have meant gdb_byte. Actually, this (not checked in yet)
series does that:
http://sourceware.org/ml/gdb-patches/2013-04/msg00327.html
Specifically this patch:
http://sourceware.org/ml/gdb-patches/2013-04/msg00328.html
> but I couldn't find any signs in the code that
> this typedef wouldn't be changed in the future to something else.
Could you write a test case? That'd prevent a regression here
going unnoticed.
--
Pedro Alves
next prev parent reply other threads:[~2013-04-18 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 15:40 Vladimir Kargov
2013-04-19 9:43 ` Pedro Alves [this message]
2013-04-19 14:30 ` Vladimir Kargov
2013-04-19 14:33 ` Pedro Alves
2013-04-19 18:23 ` Vladimir Kargov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FC7B3.4050502@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kargov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox