From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10095 invoked by alias); 19 Apr 2013 16:20:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10084 invoked by uid 89); 19 Apr 2013 16:20:46 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ie0-f173.google.com (HELO mail-ie0-f173.google.com) (209.85.223.173) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 16:20:45 +0000 Received: by mail-ie0-f173.google.com with SMTP id k5so4844519iea.4 for ; Fri, 19 Apr 2013 09:20:44 -0700 (PDT) X-Received: by 10.50.170.36 with SMTP id aj4mr9507380igc.4.1366388444181; Fri, 19 Apr 2013 09:20:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.118.35 with HTTP; Fri, 19 Apr 2013 09:20:23 -0700 (PDT) In-Reply-To: <517153B4.1060605@redhat.com> References: <516FC7B3.4050502@redhat.com> <517153B4.1060605@redhat.com> From: Vladimir Kargov Date: Fri, 19 Apr 2013 18:23:00 -0000 Message-ID: Subject: =?windows-1252?Q?Re=3A_=5BPATCH=5D_Fix_the_x87_FP_register_printout_by_=93i?= =?windows-1252?Q?nfo_float=94=2E?= To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-04/txt/msg00615.txt.bz2 On 19 April 2013 18:24, Pedro Alves wrote: > I believe printing a negative value with an unsigned format > specifier is actually undefined. I've just checked C99 and yes, it appears to be undefined after all (I actually thought that the C standard mandated a uniform representation of negative integer numbers which it didn't!), so my patch indeed exploited compiler and hardware dependent behaviour. > I'm applying the patch > I'll just point out what needed fixing, FYI. Thanks, and thank you for the review! -- Vladimir