From: Yao Qi <qiyaoltc@gmail.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"palves@redhat.com" <palves@redhat.com>
Subject: Re: [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
Date: Thu, 06 Oct 2016 12:21:00 -0000 [thread overview]
Message-ID: <CAH=s-PP67Viu4N-AwBxj_uCXYaQ94hZ7WmLjwtkVvf2SN=5yqw@mail.gmail.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B233FFE33BF@IRSMSX104.ger.corp.intel.com>
On Thu, Oct 6, 2016 at 12:03 PM, Metzger, Markus T
<markus.t.metzger@intel.com> wrote:
> As to whether the callers of frame_unwind_caller_id need to expect an exception,
> I can't say for sure but I don't think it likely. There are a few such checks in GDB
> already and none of them seems to expect an exception.
>
I suspect it may happen when we collect part of the stack in tracepoint,
switch to read data from traceframes, and do unwinding. Something on
stack may be unavailable for building frame_id.
To be clear, your patch is OK to go in. Please push it into master and
7.12. Thanks for your patience on keeping pinging this patch, and
sorry the delayed review.
--
Yao (齐尧)
prev parent reply other threads:[~2016-10-06 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 11:13 Markus Metzger
2016-10-06 9:32 ` Yao Qi
2016-10-06 11:03 ` Metzger, Markus T
2016-10-06 12:21 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PP67Viu4N-AwBxj_uCXYaQ94hZ7WmLjwtkVvf2SN=5yqw@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox