Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Cc: qiyaoltc@gmail.com, palves@redhat.com
Subject: [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
Date: Fri, 22 Jul 2016 11:13:00 -0000	[thread overview]
Message-ID: <1469185962-28925-1-git-send-email-markus.t.metzger@intel.com> (raw)

Commit a038fa3e14a4 stack: check frame_unwind_caller_id adds a frame_id check to
frame_info and treats a missing frame_id as NOT_AVAILABLE_ERROR.  This causes a
regression in gdb.dwarf2/dw2-undefined-ret-addr.exp.

Treat a missing frame_id as OPTIMIZED_OUT_ERROR instead.

See also https://sourceware.org/ml/gdb-patches/2016-07/msg00273.html.

2016-07-22  Markus Metzger  <markus.t.metzger@intel.com>

gdb/
	* stack.c (frame_info): Call val_print_not_saved instead of
	val_print_unavailable if frame_id check fails.
---
 gdb/stack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/stack.c b/gdb/stack.c
index b9e74df..9782457 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1508,7 +1508,7 @@ frame_info (char *addr_exp, int from_tty)
   printf_filtered ("saved %s = ", pc_regname);
 
   if (!frame_id_p (frame_unwind_caller_id (fi)))
-    val_print_unavailable (gdb_stdout);
+    val_print_not_saved (gdb_stdout);
   else
     {
       TRY
-- 
1.8.3.1


             reply	other threads:[~2016-07-22 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 11:13 Markus Metzger [this message]
2016-10-06  9:32 ` Yao Qi
2016-10-06 11:03   ` Metzger, Markus T
2016-10-06 12:21     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469185962-28925-1-git-send-email-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox