From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25503 invoked by alias); 6 Oct 2016 12:21:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25487 invoked by uid 89); 6 Oct 2016 12:21:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=pinging X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 12:21:02 +0000 Received: by mail-oi0-f53.google.com with SMTP id r126so19215484oib.0 for ; Thu, 06 Oct 2016 05:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=H28/Ha7gI3FOyYRRfZ6O1R/+jKYZ+2IQ0aBRIq4bkNk=; b=h2IcrN165Zg1Qi2zJlDI55HmFo78p/gdGRAHvPeGpv8aGb9e7yfYmPPgBqhvfH+y1L EOe0ZJtB/hyMQuYpfGT0yYkvXFt1wRH2BKULFLJvpoJSKuQgMB79Fa4BozEsAkFDN4hc KzgZXBzkyakSudFXHUaacfR1s43F67ID4eyuM/6ajiwP2zQcf6Xmlw88+s1f4LlrQFFN /7jUSJrVHWAg5Hwq3EuWUnnrtoheRAfRZ6ZzrCAM+KUSIHfnY9smeIKtagvIYcFkIj27 7arnGBElJIw8jfPItqNWfN7It3c7xO++6W9J31lHAfsWorsOc65++7AYBLRBgzx6lzbm /eMA== X-Gm-Message-State: AA6/9RnvpMdH0fb9fb5hgxAfeQ6hvNIy7YrIFUeF8MIGA6ibL8HCegiqnAM1b0nwPBdaQ/kXt1L8vESgyJqTlg== X-Received: by 10.202.72.77 with SMTP id v74mr10650820oia.50.1475756460890; Thu, 06 Oct 2016 05:21:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.221.3 with HTTP; Thu, 6 Oct 2016 05:21:00 -0700 (PDT) In-Reply-To: References: <1469185962-28925-1-git-send-email-markus.t.metzger@intel.com> <86shs9akm6.fsf@gmail.com> From: Yao Qi Date: Thu, 06 Oct 2016 12:21:00 -0000 Message-ID: Subject: Re: [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , "palves@redhat.com" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00117.txt.bz2 On Thu, Oct 6, 2016 at 12:03 PM, Metzger, Markus T wrote: > As to whether the callers of frame_unwind_caller_id need to expect an exc= eption, > I can't say for sure but I don't think it likely. There are a few such c= hecks in GDB > already and none of them seems to expect an exception. > I suspect it may happen when we collect part of the stack in tracepoint, switch to read data from traceframes, and do unwinding. Something on stack may be unavailable for building frame_id. To be clear, your patch is OK to go in. Please push it into master and 7.12. Thanks for your patience on keeping pinging this patch, and sorry the delayed review. --=20 Yao (=E9=BD=90=E5=B0=A7)