From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c
Date: Fri, 21 Apr 2017 14:01:00 -0000 [thread overview]
Message-ID: <CAH=s-PNULKRhnAUi4VpSV7XVcBOsJaYwT8qbQxL9vdUzk2ynog@mail.gmail.com> (raw)
In-Reply-To: <86efx0ljsv.fsf@gmail.com>
On Mon, Apr 10, 2017 at 9:59 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> This patches removes the 2nd argument of regcache_restore, because it
> is only called by regcache_cpy. In regcache_cpy, if regcache_restore
> is called, dst is not readonly, but src is readonly. So this patch
> adds an assert that src is readonly in regcache_restore.
> regcache_cook_read read everything from a readonly regcache cache
> (src)'s register_buffer, and register status is from src->register_status.
>
> gdb:
>
> 2017-04-07 Yao Qi <yao.qi@linaro.org>
>
> * regcache.c (regcache_restore): Remove argument 2. Replace
> argument 3 with regcache. Get register status from
> src->register_status and get register contents from
> register_buffer (src, regnum).
> (regcache_cpy): Update.
>
Tested it again on x86_64-linux. Pushed it in.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-04-21 14:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:19 Alan Hayward
2017-03-23 14:45 ` Alan Hayward
2017-03-24 8:49 ` Yao Qi
2017-03-24 10:28 ` Alan Hayward
2017-04-05 14:53 ` Alan Hayward
[not found] ` <868tneq1xj.fsf@gmail.com>
2017-04-05 18:10 ` Alan Hayward
2017-04-10 8:59 ` Yao Qi
2017-04-10 10:53 ` Alan Hayward
2017-04-21 14:01 ` Yao Qi [this message]
2017-04-26 14:03 ` Alan Hayward
2017-04-27 9:43 ` Yao Qi
2017-04-27 9:52 ` Alan Hayward
2017-05-03 8:21 ` Yao Qi
2017-05-03 10:42 ` Alan Hayward
2017-06-07 8:49 ` Alan Hayward
2017-06-07 9:12 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNULKRhnAUi4VpSV7XVcBOsJaYwT8qbQxL9vdUzk2ynog@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox