From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5968 invoked by alias); 21 Apr 2017 14:01:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5955 invoked by uid 89); 21 Apr 2017 14:01:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qt0-f194.google.com Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 14:01:06 +0000 Received: by mail-qt0-f194.google.com with SMTP id c45so11996892qtb.0 for ; Fri, 21 Apr 2017 07:01:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i2MO08svCFQ/VUJDEeQlzXtiKBYvX8UvlW8698uJzj8=; b=rIU1nJhvTscwHm5yN8S9HAR7V+pObxzW6suvg1e3W1nuRNZgpfQwapi4TRFDE2atl5 MlMr+fUL4qukQ3VpxtiHQZcy8hBIR5D+CkoWxcb3Apeoigqx0YylYtbKztIhztAVam46 t+jeLfqETbqS8ULwdaqON3iHX5WbW8SxsJiBUInjOLLXSW5N7xcukD1dDztseZgOwd7j 9k/NfMxQ/6nBLKDB9qei3nTBp19/sm5QbZm+OBKihaETzW+KPrLWQfk/SmUw3ZrvaRXl PmctxzDviWaGttYSEbFN/QEYbG3PqHL6pTtw8EgHC++1K48mwjawk9QYgMYeoxbknNbN 5dkw== X-Gm-Message-State: AN3rC/6yYLyjoh8nNALZnOg5EVP0VEjMhJuP8OOERho897ijnws3QANi zk0GYIL7Y7tBOXDqPPr9KKqTAMBFug== X-Received: by 10.200.44.229 with SMTP id 34mr13400585qtx.29.1492783267021; Fri, 21 Apr 2017 07:01:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.140.76 with HTTP; Fri, 21 Apr 2017 07:01:06 -0700 (PDT) In-Reply-To: <86efx0ljsv.fsf@gmail.com> References: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> <868tnvukjh.fsf@gmail.com> <7359B5C0-BF61-42E2-9886-B322C1825865@arm.com> <0DADF920-69B9-4F96-A153-6965E56B5DA8@arm.com> <868tneq1xj.fsf@gmail.com> <86efx0ljsv.fsf@gmail.com> From: Yao Qi Date: Fri, 21 Apr 2017 14:01:00 -0000 Message-ID: Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c To: Alan Hayward Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00608.txt.bz2 On Mon, Apr 10, 2017 at 9:59 AM, Yao Qi wrote: > > This patches removes the 2nd argument of regcache_restore, because it > is only called by regcache_cpy. In regcache_cpy, if regcache_restore > is called, dst is not readonly, but src is readonly. So this patch > adds an assert that src is readonly in regcache_restore. > regcache_cook_read read everything from a readonly regcache cache > (src)'s register_buffer, and register status is from src->register_status. > > gdb: > > 2017-04-07 Yao Qi > > * regcache.c (regcache_restore): Remove argument 2. Replace > argument 3 with regcache. Get register status from > src->register_status and get register contents from > register_buffer (src, regnum). > (regcache_cpy): Update. > Tested it again on x86_64-linux. Pushed it in. --=20 Yao (=E9=BD=90=E5=B0=A7)