From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Close gdbserver in mi_gdb_exit
Date: Thu, 22 Sep 2016 17:51:00 -0000 [thread overview]
Message-ID: <CAH=s-PMu2QYD6BT9wpXUpT-yYw48_7s7t3JvuFwsAcO0t=6usQ@mail.gmail.com> (raw)
In-Reply-To: <1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com>
On Thu, Sep 22, 2016 at 3:17 PM, Pedro Alves <palves@redhat.com> wrote:
>> + if { $is_mi } {
>> + set monitor_exit "-interpreter-exec console \"monitor exit\"\n"
>
> That "\n" at the end, is it stray or necessary?
>
It is not needed. Remove it and push the patch in.
>> + } else {
>> + set monitor_exit "monitor exit"
>> + }
>> + send_gdb "$monitor_exit\n";
>
> I ask because this here already includes a \n.
>
--
Yao (齐尧)
prev parent reply other threads:[~2016-09-22 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:17 Yao Qi
2016-09-22 14:27 ` Pedro Alves
2016-09-22 17:51 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PMu2QYD6BT9wpXUpT-yYw48_7s7t3JvuFwsAcO0t=6usQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox