From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22262 invoked by alias); 22 Sep 2016 15:05:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22210 invoked by uid 89); 22 Sep 2016 15:05:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-oi0-f43.google.com Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 15:05:10 +0000 Received: by mail-oi0-f43.google.com with SMTP id r126so100698816oib.0 for ; Thu, 22 Sep 2016 08:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qEuw9SmSDcvJMXHuVfmHrZG2F5F/OD1Jm88aqaPWkUQ=; b=G0epo3GiveX6BuRH2K6C7zj3FN34yHLQIagmTeKJRBjTdJz1DM4huWr7t/w+AKfQzF GOG7qUy/o0NdF8reqv/qFfVqp4xNdoF4vVize+CIsF1ZV4mJRUxJ0KnB8YpytLLyi4Xp kXLL6Ig/0UENY5Ec52u+6SE5S9CIfE3HUElG/JI60k/gbkBhRN86GsTA3xqYXUYV427H V2wpAZ57RVM/vE1uq4hAK2tg/3TbNU9COSgERC68suQXJZCtel/7V4R4lgsizH0KEnmi fWYVpBDwZW9fGdXfOFetev/IG/ycRnK24ROw8dUiISxSlwdKZOK3Xy+3GQ8ahdXqw48V 5loQ== X-Gm-Message-State: AE9vXwM8MCz2uGpimdLiRKww/xUtDoqN+gJZaQL7BsYGyX4SCf6lAO/AxuSLlP0w6XpJOkAgcavW0mC37iOIZg== X-Received: by 10.202.192.5 with SMTP id q5mr3121858oif.71.1474556708797; Thu, 22 Sep 2016 08:05:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.237.20 with HTTP; Thu, 22 Sep 2016 08:05:08 -0700 (PDT) In-Reply-To: <1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com> References: <1474552922-29654-1-git-send-email-yao.qi@linaro.org> <1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com> From: Yao Qi Date: Thu, 22 Sep 2016 17:51:00 -0000 Message-ID: Subject: Re: [PATCH] Close gdbserver in mi_gdb_exit To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00285.txt.bz2 On Thu, Sep 22, 2016 at 3:17 PM, Pedro Alves wrote: >> + if { $is_mi } { >> + set monitor_exit "-interpreter-exec console \"monitor exit= \"\n" > > That "\n" at the end, is it stray or necessary? > It is not needed. Remove it and push the patch in. >> + } else { >> + set monitor_exit "monitor exit" >> + } >> + send_gdb "$monitor_exit\n"; > > I ask because this here already includes a \n. > --=20 Yao (=E9=BD=90=E5=B0=A7)