Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Close gdbserver in mi_gdb_exit
Date: Thu, 22 Sep 2016 14:27:00 -0000	[thread overview]
Message-ID: <1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com> (raw)
In-Reply-To: <1474552922-29654-1-git-send-email-yao.qi@linaro.org>

Hi Yao,

Thanks for fixing this.

On 09/22/2016 03:02 PM, Yao Qi wrote:

> 2016-09-22  Yao Qi  <yao.qi@linaro.org>
> 
> 	* lib/gdbserver-support.exp: Rename mi_gdb_exit.
> 	(gdb_exit): Rename it to ...
> 	(gdbserver_gdb_exit): ...  Close GDBserver.
> 	(gdb_exit): New proc, call gdbserver_gdb_exit.
> 	(mi_gdb_exit): Likewise.

Looks good.

> +	    if { $is_mi } {
> +		set monitor_exit "-interpreter-exec console \"monitor exit\"\n"

That "\n" at the end, is it stray or necessary?

> +	    } else {
> +		set monitor_exit "monitor exit"
> +	    }
> +	    send_gdb "$monitor_exit\n";

I ask because this here already includes a \n.

Thanks,
Pedro Alves


  reply	other threads:[~2016-09-22 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 14:17 Yao Qi
2016-09-22 14:27 ` Pedro Alves [this message]
2016-09-22 17:51   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox