From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133421-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2247 invoked by alias); 22 Sep 2016 14:17:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2140 invoked by uid 89); 22 Sep 2016 14:17:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:670, Close
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 14:17:28 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 7A9727F7BD;	Thu, 22 Sep 2016 14:17:27 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8MEHQE2008436;	Thu, 22 Sep 2016 10:17:26 -0400
Subject: Re: [PATCH] Close gdbserver in mi_gdb_exit
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
References: <1474552922-29654-1-git-send-email-yao.qi@linaro.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <1ad780c5-0e16-63a9-a07e-a61f6240854e@redhat.com>
Date: Thu, 22 Sep 2016 14:27:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1474552922-29654-1-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-09/txt/msg00280.txt.bz2

Hi Yao,

Thanks for fixing this.

On 09/22/2016 03:02 PM, Yao Qi wrote:

> 2016-09-22  Yao Qi  <yao.qi@linaro.org>
> 
> 	* lib/gdbserver-support.exp: Rename mi_gdb_exit.
> 	(gdb_exit): Rename it to ...
> 	(gdbserver_gdb_exit): ...  Close GDBserver.
> 	(gdb_exit): New proc, call gdbserver_gdb_exit.
> 	(mi_gdb_exit): Likewise.

Looks good.

> +	    if { $is_mi } {
> +		set monitor_exit "-interpreter-exec console \"monitor exit\"\n"

That "\n" at the end, is it stray or necessary?

> +	    } else {
> +		set monitor_exit "monitor exit"
> +	    }
> +	    send_gdb "$monitor_exit\n";

I ask because this here already includes a \n.

Thanks,
Pedro Alves