From: Yao Qi <qiyaoltc@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Kevin Buettner <kevinb@redhat.com>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors]
Date: Tue, 12 Jul 2016 12:56:00 -0000 [thread overview]
Message-ID: <CAH=s-PMPWJq4Jwdi9O=osKswyBHvTbr9rTuqCg0XH+YQ-UH2Bw@mail.gmail.com> (raw)
In-Reply-To: <20160706193508.GA2313@host1.jankratochvil.net>
Hi Jan,
On Wed, Jul 6, 2016 at 8:35 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Wed, 06 Jul 2016 10:11:22 +0200, Jan Kratochvil wrote:
>> Now the question is how to detect that. I used "powerpc64-*linux*" target
>> match in my patch but I guess that is not right. Maybe it could compile first
>> something and check if ".somesymbol" exists.
>
> Implemented the compile test.
>
> It works for me on RHEL-7.2 ppc64 and on Fedora 24 x86_64.
>
> OK for check-in?
>
> I see gdb_target_symbol_prefix is by Kevin so Ccing him if he sees it OK even
> on those platforms.
I am not sure what is the best approach of detecting function descriptor, so
I copy Ulrich.
I suspect we should check whether the program is compiled with ELFv1,
in which function descriptor is used. So probably, we need to check
__powerpc64__ and (!defined(_CALL_ELF) || _CALL_ELF != 2) instead.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-07-12 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 14:55 [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors Jan Kratochvil
2016-07-06 7:51 ` Yao Qi
2016-07-06 8:11 ` Jan Kratochvil
2016-07-06 19:35 ` [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors] Jan Kratochvil
2016-07-12 12:56 ` Yao Qi [this message]
2016-07-12 13:22 ` [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target Ulrich Weigand
2016-07-13 8:54 ` [testsuite patchv3] " Jan Kratochvil
2016-07-13 11:52 ` Ulrich Weigand
2016-07-13 12:02 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PMPWJq4Jwdi9O=osKswyBHvTbr9rTuqCg0XH+YQ-UH2Bw@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=kevinb@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox