Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	       Kevin Buettner <kevinb@redhat.com>
Subject: [commit] [testsuite patchv3] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target
Date: Wed, 13 Jul 2016 12:02:00 -0000	[thread overview]
Message-ID: <20160713120211.GA31899@host1.jankratochvil.net> (raw)
In-Reply-To: <20160713115149.D85A52397@oc7340732750.ibm.com>

On Wed, 13 Jul 2016 13:51:49 +0200, Ulrich Weigand wrote:
> >From what I can see, it should indeed not be needed: the <func>_label symbols
> are defined by assembler code directly, and therefore gdb_target_symbol does
> not apply, while the compiler-defined symbols like <func> are only accessed
> via GDB commands in function_range (and GDB should already do the right thing
> w.r.t. symbol prefixes).

OK.


> The patch is OK.

Checked in:
	e87324746c45b0f2cd179ba59a80b43a435a9369


Thanks,
Jan


      reply	other threads:[~2016-07-13 12:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 14:55 [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors Jan Kratochvil
2016-07-06  7:51 ` Yao Qi
2016-07-06  8:11   ` Jan Kratochvil
2016-07-06 19:35     ` [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors] Jan Kratochvil
2016-07-12 12:56       ` Yao Qi
2016-07-12 13:22         ` [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target Ulrich Weigand
2016-07-13  8:54           ` [testsuite patchv3] " Jan Kratochvil
2016-07-13 11:52             ` Ulrich Weigand
2016-07-13 12:02               ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160713120211.GA31899@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=qiyaoltc@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox