From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92991 invoked by alias); 13 Jul 2016 12:02:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92969 invoked by uid 89); 13 Jul 2016 12:02:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:630 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Jul 2016 12:02:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FF9178222; Wed, 13 Jul 2016 12:02:16 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-204-80.brq.redhat.com [10.40.204.80]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6DC2CEF018556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 13 Jul 2016 08:02:14 -0400 Date: Wed, 13 Jul 2016 12:02:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: Yao Qi , "gdb-patches@sourceware.org" , Kevin Buettner Subject: [commit] [testsuite patchv3] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target Message-ID: <20160713120211.GA31899@host1.jankratochvil.net> References: <20160713085400.GA1159@host1.jankratochvil.net> <20160713115149.D85A52397@oc7340732750.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160713115149.D85A52397@oc7340732750.ibm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00144.txt.bz2 On Wed, 13 Jul 2016 13:51:49 +0200, Ulrich Weigand wrote: > >From what I can see, it should indeed not be needed: the _label symbols > are defined by assembler code directly, and therefore gdb_target_symbol does > not apply, while the compiler-defined symbols like are only accessed > via GDB commands in function_range (and GDB should already do the right thing > w.r.t. symbol prefixes). OK. > The patch is OK. Checked in: e87324746c45b0f2cd179ba59a80b43a435a9369 Thanks, Jan