From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79004 invoked by alias); 12 Jul 2016 12:56:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78988 invoked by uid 89); 12 Jul 2016 12:56:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Kevin, Implemented, Hx-languages-length:1071, descriptors X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 Jul 2016 12:56:43 +0000 Received: by mail-oi0-f67.google.com with SMTP id c199so1113645oig.1 for ; Tue, 12 Jul 2016 05:56:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wJzYUAkUvJgb5ISMpiU/xtLZbnx75LFAGcMkXcrxe9E=; b=S3KkWXQS0LwydEvFLieY9SnYr8+WS9RRknKTNNe9qYY4v8iv/rpvPgRYGcJkE4OfFT ls6VHbmTNS5hMUZAKATL1Z03ddPOdiKg+iSqoakQkPrUVymrJdU0XLTJG2IsNpsFFwJs DmobnJvpMtzd0LV5xrZxUDEojKSEmdWvmprVDH8ndeV6+hu2qN0mRWrLFyrQl3dlP3gM ye5Ntm2DwG0OzofKqWEHEk8W9fpx/nuYHpY8+Gq30ubHznq7p+/x8tz0pG6wOxIUdYjX TKpj5T+npzt9MHuAzzZv4CIlYp6TWhKsnb3ytaHAQWVW/JFbGykXssjD9phJiz/dMtik 7k6w== X-Gm-Message-State: ALyK8tI+bn/7oSregXVJSXs7VCoetGbCNzFkha0tZy8ihWYNb4uPo5sKRiZ1ckzvn+V1B5wywUSISTHv717Ftg== X-Received: by 10.157.15.236 with SMTP id m41mr1208757otd.3.1468328201440; Tue, 12 Jul 2016 05:56:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.182.130 with HTTP; Tue, 12 Jul 2016 05:56:36 -0700 (PDT) In-Reply-To: <20160706193508.GA2313@host1.jankratochvil.net> References: <20160705145454.GA26978@host1.jankratochvil.net> <20160706081122.GA19754@host1.jankratochvil.net> <20160706193508.GA2313@host1.jankratochvil.net> From: Yao Qi Date: Tue, 12 Jul 2016 12:56:00 -0000 Message-ID: Subject: Re: [testsuite patchv2] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target_symbol does not support function descriptors] To: Jan Kratochvil Cc: "gdb-patches@sourceware.org" , Kevin Buettner , Ulrich Weigand Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00126.txt.bz2 Hi Jan, On Wed, Jul 6, 2016 at 8:35 PM, Jan Kratochvil wrote: > On Wed, 06 Jul 2016 10:11:22 +0200, Jan Kratochvil wrote: >> Now the question is how to detect that. I used "powerpc64-*linux*" targ= et >> match in my patch but I guess that is not right. Maybe it could compile= first >> something and check if ".somesymbol" exists. > > Implemented the compile test. > > It works for me on RHEL-7.2 ppc64 and on Fedora 24 x86_64. > > OK for check-in? > > I see gdb_target_symbol_prefix is by Kevin so Ccing him if he sees it OK = even > on those platforms. I am not sure what is the best approach of detecting function descriptor, so I copy Ulrich. I suspect we should check whether the program is compiled with ELFv1, in which function descriptor is used. So probably, we need to check __powerpc64__ and (!defined(_CALL_ELF) || _CALL_ELF !=3D 2) instead. --=20 Yao (=E9=BD=90=E5=B0=A7)