From: Siva Chandra <sivachandra@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
Date: Thu, 16 Oct 2014 18:10:00 -0000 [thread overview]
Message-ID: <CAGyQ6gz3DfAA52yh0ANFyJycMnAc5oQLmG6p+x6R70G7cbmuYQ@mail.gmail.com> (raw)
In-Reply-To: <544007F1.9010005@redhat.com>
On Thu, Oct 16, 2014 at 11:01 AM, Pedro Alves <palves@redhat.com> wrote:
>> 2014-10-16 Siva Chandra Reddy <sivachandra@google.com>
>>
>> * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE
>> on the arg type of a constructor only if it is of reference type.
>>
>
> How did you notice this? Does an existing test catch it?
I hit it while I was "using" GDB so to say :)
I had a class which had a copy constructor as well as another
constructor taking an argument. It fails when going over the other
constructor.
Do you think a test case should be added? I did think about it, but
then, should there be a test case for every use of TYPE_TARGET_TYPE? I
thought it was more of a "user mistake" in my original patch.
Thank you,
Siva Chandra
next prev parent reply other threads:[~2014-10-16 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 14:38 Siva Chandra
2014-10-16 18:01 ` Pedro Alves
2014-10-16 18:10 ` Siva Chandra [this message]
2014-10-16 18:16 ` Sergio Durigan Junior
2014-10-16 18:18 ` Siva Chandra
2014-10-16 18:28 ` Sergio Durigan Junior
2014-10-16 19:01 ` Siva Chandra
2014-10-16 20:42 ` Pedro Alves
2014-10-23 19:09 ` Siva Chandra
2014-10-24 5:31 ` Doug Evans
2014-10-24 12:56 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGyQ6gz3DfAA52yh0ANFyJycMnAc5oQLmG6p+x6R70G7cbmuYQ@mail.gmail.com \
--to=sivachandra@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox