From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3010 invoked by alias); 16 Oct 2014 18:10:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3000 invoked by uid 89); 16 Oct 2014 18:10:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f54.google.com Received: from mail-oi0-f54.google.com (HELO mail-oi0-f54.google.com) (209.85.218.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 18:10:28 +0000 Received: by mail-oi0-f54.google.com with SMTP id v63so3100568oia.13 for ; Thu, 16 Oct 2014 11:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9hPZ+oLeLTF57wRmEE+E5q8QbiA6T5G4DxEV9Uterd8=; b=Cccg/sQ3gJh7J3RWY7+BfyFuLv3DrRCzInIq8fmkwDWCIWd49oA4xotKrBDkNlis9w 4Ix23vSfv4YxekPdhbioBeljr6m76Tl4muL4uCSX9WZjuyCWpfwU8H9uxPlHqARoGZ33 QwNL4vQdGDx9NcS5qImvZEUqMtqx0Z7W1hUPmNgHUdiAqgD52Y7NWJrb7DfgFTnsN6af 3F0JkiQJ+c185oS2ev2yWb0apLzTaIKPtoejHhs35ohc59Ob33dRm58BE7ZWxR/APfzb eRtMkyYHFf3nv1Idj3jdc9RmNoePecAOwYLbnQ8vzuzOAP1STfAy11A4V6bgRLL1JBUK Uj9g== X-Gm-Message-State: ALoCoQlO800QgN4yxAuKAD8XupEjLrpHDYPG/EZjvm1tsaeUDMWIpiFw3ON2MRzCTeSW61GPKehl MIME-Version: 1.0 X-Received: by 10.182.234.35 with SMTP id ub3mr2307154obc.37.1413483026124; Thu, 16 Oct 2014 11:10:26 -0700 (PDT) Received: by 10.202.197.13 with HTTP; Thu, 16 Oct 2014 11:10:26 -0700 (PDT) In-Reply-To: <544007F1.9010005@redhat.com> References: <544007F1.9010005@redhat.com> Date: Thu, 16 Oct 2014 18:10:00 -0000 Message-ID: Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference From: Siva Chandra To: Pedro Alves Cc: Doug Evans , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00432.txt.bz2 On Thu, Oct 16, 2014 at 11:01 AM, Pedro Alves wrote: >> 2014-10-16 Siva Chandra Reddy >> >> * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE >> on the arg type of a constructor only if it is of reference type. >> > > How did you notice this? Does an existing test catch it? I hit it while I was "using" GDB so to say :) I had a class which had a copy constructor as well as another constructor taking an argument. It fails when going over the other constructor. Do you think a test case should be added? I did think about it, but then, should there be a test case for every use of TYPE_TARGET_TYPE? I thought it was more of a "user mistake" in my original patch. Thank you, Siva Chandra