From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
Date: Fri, 24 Oct 2014 05:31:00 -0000 [thread overview]
Message-ID: <CADPb22SL8CCmRn22qfGOsSkqtyC86udXTQAf-BK2AcsPUdn7cw@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gzXKBQ4JVOZeEUAc3fvDtXJ+yACsU74rL2Q4cnO4JTh+g@mail.gmail.com>
On Thu, Oct 23, 2014 at 12:09 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Oct 16, 2014 at 12:01 PM, Siva Chandra <sivachandra@google.com> wrote:
>> The patch updated with a test case is attached.
>>
>> gdb/ChangeLog:
>>
>> * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE
>> on the arg type of a constructor only if it is of reference type.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.cp/non-trivial-retval.cc: Add a test case.
>> * gdb.cp/non-trivial-retval.exp: Add a test.
>
> Ping.
LGTM with one nit.
+class B1
+{
+public:
+ B1 () {}
+ B1 (int i); /* Put this decl before the copy-ctor decl. */
+ B1 (const B1 &obj);
+
+ int b1;
+};
Can you elaborate on why "Put this decl before ..."?
next prev parent reply other threads:[~2014-10-24 5:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 14:38 Siva Chandra
2014-10-16 18:01 ` Pedro Alves
2014-10-16 18:10 ` Siva Chandra
2014-10-16 18:16 ` Sergio Durigan Junior
2014-10-16 18:18 ` Siva Chandra
2014-10-16 18:28 ` Sergio Durigan Junior
2014-10-16 19:01 ` Siva Chandra
2014-10-16 20:42 ` Pedro Alves
2014-10-23 19:09 ` Siva Chandra
2014-10-24 5:31 ` Doug Evans [this message]
2014-10-24 12:56 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22SL8CCmRn22qfGOsSkqtyC86udXTQAf-BK2AcsPUdn7cw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox