From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116948-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27085 invoked by alias); 24 Oct 2014 05:31:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27074 invoked by uid 89); 24 Oct 2014 05:31:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yh0-f50.google.com
Received: from mail-yh0-f50.google.com (HELO mail-yh0-f50.google.com) (209.85.213.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 24 Oct 2014 05:31:11 +0000
Received: by mail-yh0-f50.google.com with SMTP id a41so2761553yho.23        for <gdb-patches@sourceware.org>; Thu, 23 Oct 2014 22:31:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=5QT0ne3xNgXTkhrDrf0gwmZa4bqhgi875txwg1qd7/Y=;        b=HWDiRB9+ayW1vnqbDKOn3dkh/t70l3w44KdYj7Q5+jN8inb0jYsjeT+ScOCyM2Ewop         O4JDWu3z+n7Y+sRzP9tZsa9nwKsdt7zYPMn0dqe0B9nSTzrDdVhVExwW9NaKDe80Z05X         KFyqJUDvsqcxMaFHmewJsHqEX6qHEXp9jQ9aX5k9lJoZZ6GmzV3FeHj+TxmcqdhM9uCH         tmsafyQGc6Z1hkbKLjQES7I1AuO3bRy8mHZBVejQX2rK6d05HlyM1URhyhn7g7/2O0mg         AdeFevfv8sstEZu60stXIkxgI9Wrh4BfSQ+Tbtpyiy7/SaGAjDSga2yH3OnDa5vkEF8P         FVig==
X-Gm-Message-State: ALoCoQnm5lflGjMHAkH1rqG/Iyq3X4r0zVFTXA1vPiADj/h3xWvzBx3t6KLHtpXNiJb91bXgWybu
MIME-Version: 1.0
X-Received: by 10.170.100.215 with SMTP id r206mr2875619yka.19.1414128669776; Thu, 23 Oct 2014 22:31:09 -0700 (PDT)
Received: by 10.229.250.4 with HTTP; Thu, 23 Oct 2014 22:31:09 -0700 (PDT)
In-Reply-To: <CAGyQ6gzXKBQ4JVOZeEUAc3fvDtXJ+yACsU74rL2Q4cnO4JTh+g@mail.gmail.com>
References: <CAGyQ6gzAMpiA8Hwt1=DqmFxXjfe44nqGsCqsj-fx=ObJbgPAsA@mail.gmail.com>	<CAGyQ6gy9eObF+29DSibKj4xxiw9NpoWtarVJTtd-j_A7LBnktA@mail.gmail.com>	<CAGyQ6gzXKBQ4JVOZeEUAc3fvDtXJ+yACsU74rL2Q4cnO4JTh+g@mail.gmail.com>
Date: Fri, 24 Oct 2014 05:31:00 -0000
Message-ID: <CADPb22SL8CCmRn22qfGOsSkqtyC86udXTQAf-BK2AcsPUdn7cw@mail.gmail.com>
Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00624.txt.bz2

On Thu, Oct 23, 2014 at 12:09 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Oct 16, 2014 at 12:01 PM, Siva Chandra <sivachandra@google.com> wrote:
>> The patch updated with a test case is attached.
>>
>> gdb/ChangeLog:
>>
>>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE
>>         on the arg type of a constructor only if it is of reference type.
>>
>> gdb/testsuite/ChangeLog:
>>
>>         * gdb.cp/non-trivial-retval.cc: Add a test case.
>>         * gdb.cp/non-trivial-retval.exp: Add a test.
>
> Ping.

LGTM with one nit.

+class B1
+{
+public:
+  B1 () {}
+  B1 (int i);  /* Put this decl before the copy-ctor decl.  */
+  B1 (const B1 &obj);
+
+  int b1;
+};

Can you elaborate on why "Put this decl before ..."?