Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, Matt Rice <ratmice@gmail.com>,
		Phil Muldoon <pmuldoon@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sourceware.org
Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
Date: Fri, 20 Apr 2012 19:57:00 -0000	[thread overview]
Message-ID: <CAGyQ6gxAs2i+f0K5SGKV2h+Ltg439PVYSRuuD1BcMCGObi20Wg@mail.gmail.com> (raw)
In-Reply-To: <CADPb22RMzJpQDGhDU3b=R_sL2y_wd5y+qGJ+1t0sqbNWioPn9w@mail.gmail.com>

Siva> Similarly, if my
Siva> understanding is correct, static functions and static variables
Siva> defined in a source file should always be present in a static block.
Siva> Hence, we again document saying that the user rely only on this
Siva> information being constant.  Does this sound reasonable?

Matt> the following from (possibly outdated) symtab.c stuff is what i did
Matt> find, i believe there is other uncommented occurrences, anyhow given
Matt> the fudge and lack of errors I wouldn't be suprised to weirdness here
Matt> go unnoticed.

Tom> I've always assumed these comments are just wrong.
Tom> If this can really happen, then the bug should be fixed in the symbol
Tom> readers, not hacked around elsewhere.  IMNSHO of course.

Doug> Yep.
Doug> Something I hope attention to the symbol handling will dig into.

To be frank, I do not understand much of the code in dwarf2read.c yet.
 However, I focused on functions and variables in my comment because
LOCAL and GLOBAL bindings in a file are present right in the ELF
.symtab section. If at all something is not being classified correctly
in GDB, then it should be a bug  (not necessarily in GDB?).  I did not
talk about types because they are treated as static when compiled as a
C program, and as global when compiled as a C++ program (in fact, I
thought this was Doug's concern to begin with!).

Overall, wrt this patch, what should we conclude?

Thanks,
Siva Chandra


  reply	other threads:[~2012-04-20 19:53 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  8:39 Siva Chandra
2012-04-17 13:00 ` Phil Muldoon
2012-04-17 17:34   ` Siva Chandra
2012-04-17 17:44     ` Tom Tromey
2012-04-17 17:41   ` Tom Tromey
2012-04-17 17:05 ` Eli Zaretskii
     [not found]   ` <CAGyQ6gxxEeYeCKw_iHXh74Gg223GHxMoW=gvt9kU+ax396kKBQ@mail.gmail.com>
2012-04-18  9:15     ` Siva Chandra
2012-04-18 20:45       ` Phil Muldoon
2012-04-18 20:48         ` Tom Tromey
2012-04-19 17:33           ` Siva Chandra
2012-04-19 19:18             ` Doug Evans
2012-04-20  6:48               ` Siva Chandra
2012-04-20 12:12                 ` Matt Rice
2012-04-20 14:16                   ` Doug Evans
2012-04-20 15:21                   ` Matt Rice
2012-04-20 19:12                   ` Tom Tromey
2012-04-20 19:53                     ` Doug Evans
2012-04-20 19:57                       ` Siva Chandra [this message]
2012-04-23 13:21                         ` Tom Tromey
2012-04-23 13:35                           ` Phil Muldoon
2012-04-23 14:11                             ` Eli Zaretskii
2012-04-23 14:45                               ` Phil Muldoon
2012-04-23 16:00                                 ` Eli Zaretskii
2012-04-24 11:15                                   ` Siva Chandra
2012-04-24 17:40                                     ` Eli Zaretskii
2012-04-25  7:11                                   ` Tom Tromey
2012-04-25  8:19                                     ` Siva Chandra
2012-04-26 12:35                                     ` Siva Chandra
2012-04-26 15:21                                       ` Doug Evans
2012-05-02 17:41                                         ` Siva Chandra
2012-05-02 18:15                                           ` Doug Evans
2012-05-03  7:13                                             ` Siva Chandra
2012-05-04 18:05                                               ` FAILing new testcase for -fdebug-types-section [Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)] Jan Kratochvil
2012-05-05  7:01                                                 ` Siva Chandra
2012-05-05  7:05                                                   ` Jan Kratochvil
2012-05-05  7:11                                                     ` Siva Chandra
2012-05-05  7:13                                                       ` Jan Kratochvil
2012-05-23 21:38                                                         ` [patch KFAIL] Re: FAILing new testcase for -fdebug-types-section (PR symtab/14148) Jan Kratochvil
2012-04-18 20:48       ` [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included) Tom Tromey
2012-04-20  8:13       ` Eli Zaretskii
2012-04-17 17:37 ` Tom Tromey
2012-04-18 18:41   ` Tom Tromey
2012-04-18 19:53     ` Siva Chandra
2012-04-18 20:49       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyQ6gxAs2i+f0K5SGKV2h+Ltg439PVYSRuuD1BcMCGObi20Wg@mail.gmail.com \
    --to=sivachandra@google.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=ratmice@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox