From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, sivachandra@google.com, dje@google.com,
ratmice@gmail.com, gdb-patches@sourceware.org
Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
Date: Mon, 23 Apr 2012 14:45:00 -0000 [thread overview]
Message-ID: <4F95630D.1000202@redhat.com> (raw)
In-Reply-To: <83y5pmft8k.fsf@gnu.org>
On 04/23/2012 02:55 PM, Eli Zaretskii wrote:
>> Date: Mon, 23 Apr 2012 14:30:02 +0100
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> CC: Siva Chandra <sivachandra@google.com>, Doug Evans <dje@google.com>,
>> Matt Rice <ratmice@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>> gdb-patches@sourceware.org
>>
>> On 04/23/2012 02:17 PM, Tom Tromey wrote:
>>>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>>>
>>> Siva> Overall, wrt this patch, what should we conclude?
>>>
>>> I think the patch is fine, and we're just discussing what exactly the
>>> manual should say.
>>
>> My view is that we should not say anything, that it will just be
>> confusing to the user. There is no user facing concept of a "static"
>> or "global" block in GDB other than the Python API anyway.
>
> We cannot have 2 separate APIs, one called Symtab.global_block, the
> other Symtab.static_block, without saying at least _something_ about
> what these names are about.
>
> Also, the Python API to GDB _is_ user-level.
>
> Apologies if I am missing the context of what you said.
I agree, and we have documentation and an API for is_static block and
is_global block APIs already. Describing what they are now,
contextually, is fine -- no problem with that. I am just not sure we
should have compatibility warnings that the content/structure of these
blocks may change in some undefined way, at some future time. I think
we should document it when, and if that happens, and what, if any,
ramifications may occur.
Arguable the above warning could apply to most of the Python API. We
tend to just deal with it in the API when it happens. While I
understand the well-meaning thought behind this, I am not sure it is
prudent to start this trend now. We have an API promise to
specifically deal with these issues. If we start warning that in the
future this feature might change, are we just creating loop-holes for
the API promise? In fact my benchmark for exporting something to the
Python API is testing the likely-hood if it will change in the near
future. But, to date, I find that most of GDB remains fairly
constant.
And finally, yeah that is what I mean: Python is the only user-facing
API for these attributes. There is no conflict between something in
the CLI and something in Python.
Cheers,
Phil
next prev parent reply other threads:[~2012-04-23 14:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 8:39 Siva Chandra
2012-04-17 13:00 ` Phil Muldoon
2012-04-17 17:34 ` Siva Chandra
2012-04-17 17:44 ` Tom Tromey
2012-04-17 17:41 ` Tom Tromey
2012-04-17 17:05 ` Eli Zaretskii
[not found] ` <CAGyQ6gxxEeYeCKw_iHXh74Gg223GHxMoW=gvt9kU+ax396kKBQ@mail.gmail.com>
2012-04-18 9:15 ` Siva Chandra
2012-04-18 20:45 ` Phil Muldoon
2012-04-18 20:48 ` Tom Tromey
2012-04-19 17:33 ` Siva Chandra
2012-04-19 19:18 ` Doug Evans
2012-04-20 6:48 ` Siva Chandra
2012-04-20 12:12 ` Matt Rice
2012-04-20 14:16 ` Doug Evans
2012-04-20 15:21 ` Matt Rice
2012-04-20 19:12 ` Tom Tromey
2012-04-20 19:53 ` Doug Evans
2012-04-20 19:57 ` Siva Chandra
2012-04-23 13:21 ` Tom Tromey
2012-04-23 13:35 ` Phil Muldoon
2012-04-23 14:11 ` Eli Zaretskii
2012-04-23 14:45 ` Phil Muldoon [this message]
2012-04-23 16:00 ` Eli Zaretskii
2012-04-24 11:15 ` Siva Chandra
2012-04-24 17:40 ` Eli Zaretskii
2012-04-25 7:11 ` Tom Tromey
2012-04-25 8:19 ` Siva Chandra
2012-04-26 12:35 ` Siva Chandra
2012-04-26 15:21 ` Doug Evans
2012-05-02 17:41 ` Siva Chandra
2012-05-02 18:15 ` Doug Evans
2012-05-03 7:13 ` Siva Chandra
2012-05-04 18:05 ` FAILing new testcase for -fdebug-types-section [Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)] Jan Kratochvil
2012-05-05 7:01 ` Siva Chandra
2012-05-05 7:05 ` Jan Kratochvil
2012-05-05 7:11 ` Siva Chandra
2012-05-05 7:13 ` Jan Kratochvil
2012-05-23 21:38 ` [patch KFAIL] Re: FAILing new testcase for -fdebug-types-section (PR symtab/14148) Jan Kratochvil
2012-04-18 20:48 ` [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included) Tom Tromey
2012-04-20 8:13 ` Eli Zaretskii
2012-04-17 17:37 ` Tom Tromey
2012-04-18 18:41 ` Tom Tromey
2012-04-18 19:53 ` Siva Chandra
2012-04-18 20:49 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F95630D.1000202@redhat.com \
--to=pmuldoon@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
--cc=sivachandra@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox