From: Orgad Shaneh via Gdb-patches <gdb-patches@sourceware.org>
To: Orgad Shaneh <orgads@gmail.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: fix compilation on mingw64
Date: Fri, 29 Oct 2021 08:37:59 +0300 [thread overview]
Message-ID: <CAGHpTBLVo1YAQs=ujejZethq3tiMQFU_2H6ekx6WyqYOQP=WOw@mail.gmail.com> (raw)
In-Reply-To: <YXuFWh+HTD2m/mbS@vapier>
בתאריך יום ו׳, 29 באוק׳ 2021, 8:23, מאת Mike Frysinger <vapier@gentoo.org>:
> On 28 Oct 2021 09:07, Orgad Shaneh via Gdb-patches wrote:
> > ...by reordering includes.
> >
> > 1. sim-utils.c
> >
> > sim/mips/sim-main.h defines UserMode, while there is a struct in winnt.h
> > which has UserMode as a member. So if sim-main.h is included before
> winnt.h,
> > compilation fails.
> >
> > 2. ppc
> >
> > registers.h defines CR, which is used as a member in winnt.h.
> >
> > winsock2.h is included by sys/time.h, so sys/time.h has to be included
> > before registers.h.
>
> these changes lgtm, thanks!
>
> if you need me to push, lmk.
> -mike
Please do.
prev parent reply other threads:[~2021-10-29 5:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 6:27 Orgad Shaneh via Gdb-patches
2021-10-27 9:33 ` Mike Frysinger via Gdb-patches
2021-10-28 9:07 ` Orgad Shaneh via Gdb-patches
2021-10-29 5:23 ` Mike Frysinger via Gdb-patches
2021-10-29 5:37 ` Orgad Shaneh via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGHpTBLVo1YAQs=ujejZethq3tiMQFU_2H6ekx6WyqYOQP=WOw@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox