From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iBBROdeIe2GnVQAAWB0awg (envelope-from ) for ; Fri, 29 Oct 2021 01:38:31 -0400 Received: by simark.ca (Postfix, from userid 112) id D965D1F0BB; Fri, 29 Oct 2021 01:38:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 37E9A1E813 for ; Fri, 29 Oct 2021 01:38:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B3C13858416 for ; Fri, 29 Oct 2021 05:38:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B3C13858416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635485910; bh=pmO41fAgAEgdkduihBxB5oXLKCrTQ59OCnJft4kSpI4=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=pQ1kE2ErG+bptBpWxCVJv/QRa+kWGxfsU/Jn+8kYuINSi39Yse0zmZod3/BGAGG00 kiPLWhpniXRpD9a7ULXxIP6HiKerpt46cyXfAmi8K/EAkMg2wdgFZBZwXuddfTZlHe B1foM28FZf1r1dueY9vhxShro2NJmRG57rH2FBvk= Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 5C71E3858C39 for ; Fri, 29 Oct 2021 05:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C71E3858C39 Received: by mail-pj1-x1031.google.com with SMTP id oa4so6447068pjb.2 for ; Thu, 28 Oct 2021 22:38:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=+GKCxxmB6V6ysOmZrjmEzA5owNXyCM3VkjQTuFs8jjU=; b=HsUjnQBx7qucsksRneG2r72HNdqDsZTR0E69ZHJfSyKHP9wdlwYcjNQABPNqqJDc6B ZqCzepbNaMXjLsSX4pMGyyAEskuQZwc42OtI1hc0vCB63/mQyw1VClEwZReCmggmik3/ Ct5eUzJ+CITGFqjtXN6q9f4VwSLXAVn+fyh+cfKXkklp1mWPvmGBFa6ZyMMkYwmKTnvt MwvxOA0+1B4YyNwf8j7B2liJSrZvF/5L8XRn0th0eD53PoHwv9Pr4aooeBJgW0KTMCJL 6YYNR6lI+xoYGlTDt0KIK7mbs5///xgNqTQi7F6ZXr0vrgapRUL6ly2S2Vwm13UJMRfH QFAQ== X-Gm-Message-State: AOAM531ozqY59LzjML2z7oq6zdHSxIriBof7ZWU/wkAn6Vr/LuvWJ2eD ZQyiNHbS8E7LxNTxndQaNlL+iUmd111or74ZKJk3Q2kxrTQ= X-Google-Smtp-Source: ABdhPJxpf+yrhKI/5yNmFLfVYTnfZ/NudQuCEXyIF7JwrCLA2l4k08cQIvCpOKrtKduR/1hGJ+7lZqPvkPzFevK9GrE= X-Received: by 2002:a17:90b:3843:: with SMTP id nl3mr9290414pjb.147.1635485890345; Thu, 28 Oct 2021 22:38:10 -0700 (PDT) MIME-Version: 1.0 References: <20211027062703.3056254-1-orgads@gmail.com> <20211028090746.241734-1-orgads@gmail.com> In-Reply-To: Date: Fri, 29 Oct 2021 08:37:59 +0300 Message-ID: Subject: Re: [PATCH] sim: fix compilation on mingw64 To: Orgad Shaneh , gdb-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Orgad Shaneh via Gdb-patches Reply-To: Orgad Shaneh Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" =D7=91=D7=AA=D7=90=D7=A8=D7=99=D7=9A =D7=99=D7=95=D7=9D =D7=95=D7=B3, 29 = =D7=91=D7=90=D7=95=D7=A7=D7=B3 2021, 8:23, =D7=9E=D7=90=D7=AA Mike Frysinge= r =E2=80=8F: > On 28 Oct 2021 09:07, Orgad Shaneh via Gdb-patches wrote: > > ...by reordering includes. > > > > 1. sim-utils.c > > > > sim/mips/sim-main.h defines UserMode, while there is a struct in winnt.= h > > which has UserMode as a member. So if sim-main.h is included before > winnt.h, > > compilation fails. > > > > 2. ppc > > > > registers.h defines CR, which is used as a member in winnt.h. > > > > winsock2.h is included by sys/time.h, so sys/time.h has to be included > > before registers.h. > > these changes lgtm, thanks! > > if you need me to push, lmk. > -mike Please do.