From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Orgad Shaneh <orgads@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: fix compilation on mingw64
Date: Wed, 27 Oct 2021 05:33:38 -0400 [thread overview]
Message-ID: <YXkc8lYc5BEveU1Q@vapier> (raw)
In-Reply-To: <20211027062703.3056254-1-orgads@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 27 Oct 2021 06:27, Orgad Shaneh via Gdb-patches wrote:
> 1. reorder includes in sim-utils.c.
>
> sim/mips/sim-main.h defines UserMode, while there is a struct in winnt.h
> which has UserMode as a member. So if sim-main.h is included before winnt.h,
> compilation fails.
this looks fine, and is the direction we've been taking code -- include the
standard headers first, then the sim-specific headers. we haven't gone back
through all the files and fixed the order since it (largely) hasn't been an
issue.
> 2. pre-include winsock2.h in ppc
>
> registers.h defines CR, which is used as a member in winnt.h.
defs.h has a very specific meaning/role in life: include config.h and that's
it. we don't want to stuff it full of other random headers.
instead, let's find a fix similar to your sim-utils.c change.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-27 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 6:27 Orgad Shaneh via Gdb-patches
2021-10-27 9:33 ` Mike Frysinger via Gdb-patches [this message]
2021-10-28 9:07 ` Orgad Shaneh via Gdb-patches
2021-10-29 5:23 ` Mike Frysinger via Gdb-patches
2021-10-29 5:37 ` Orgad Shaneh via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXkc8lYc5BEveU1Q@vapier \
--to=gdb-patches@sourceware.org \
--cc=orgads@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox