Re: [PATCH v5] gdb: set filename-display shortpath support

[Azat Khuzhin <a3at.mail@gmail.com>]

On Wed, Dec 11, 2013 at 1:04 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Azat" == Azat Khuzhin <a3at.mail@gmail.com> writes:
>
> Azat> Display only non-common part of filename and compilation directory
> Azat> This will be useful for projects that use separate build directory
> Azat> inside project (like build/cmake and others).
>
> Thanks for doing this.
>
> Azat> 2013-12-00  Azat Khuzhin  <a3at.mail@gmail.com>
> Azat>   * source.h (symtab_to_shortpath): Add it.
> Azat>   * source.c (filename_display): Add shortpath display.
> Azat>   * (symtab_to_filename_for_display): Use symtab_to_shortpath.
>
> That final line doesn't need the "* ".
> Silly ChangeLogs.
>
> I think this patch needs at least a documentation patch and a NEWS
> entry.

Should I do this? If yes, into which file I must add this info?

>
> A test case would be nice, an addition to an existing test would be
> sufficient.

I will add it later.

>
> Do you have copyright assignment paperwork in place?

Yes, I already sign it.

> If not then please contact me off-list so I can get you started.
>
> Azat> +/* Returns only non-common part of filename and compilation directory. */
> Azat> +extern const char *symtab_to_shortpath(struct symtab *symtab);
>
> Space before the open paren here.

Oh, sorry. Fixed in new patch.
I will resent the patch with coding style fixes.
Thanks!

>
> Tom



-- 
Respectfully
Azat Khuzhin