Re: [PATCH v5] gdb: set filename-display shortpath support

[Tom Tromey <tromey@redhat.com>]

>>>>> "Azat" == Azat Khuzhin <a3at.mail@gmail.com> writes:

Azat> Display only non-common part of filename and compilation directory
Azat> This will be useful for projects that use separate build directory
Azat> inside project (like build/cmake and others).

Thanks for doing this.

Azat> 2013-12-00  Azat Khuzhin  <a3at.mail@gmail.com>
Azat> 	* source.h (symtab_to_shortpath): Add it.
Azat> 	* source.c (filename_display): Add shortpath display.
Azat> 	* (symtab_to_filename_for_display): Use symtab_to_shortpath.

That final line doesn't need the "* ".
Silly ChangeLogs.

I think this patch needs at least a documentation patch and a NEWS
entry.

A test case would be nice, an addition to an existing test would be
sufficient.

Do you have copyright assignment paperwork in place?
If not then please contact me off-list so I can get you started.

Azat> +/* Returns only non-common part of filename and compilation directory. */
Azat> +extern const char *symtab_to_shortpath(struct symtab *symtab);

Space before the open paren here.

Tom