From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7723 invoked by alias); 10 Dec 2013 21:04:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7711 invoked by uid 89); 10 Dec 2013 21:04:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Dec 2013 21:04:41 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBAL4Ukv011412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Dec 2013 16:04:30 -0500 Received: from barimba (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBAL4Sv4011563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 10 Dec 2013 16:04:29 -0500 From: Tom Tromey To: Azat Khuzhin Cc: gdb-patches@sourceware.org, eliz@gnu.org, brobecker@adacore.com, palves@redhat.com Subject: Re: [PATCH v5] gdb: set filename-display shortpath support References: <1386624043-11077-1-git-send-email-a3at.mail@gmail.com> Date: Tue, 10 Dec 2013 21:04:00 -0000 In-Reply-To: <1386624043-11077-1-git-send-email-a3at.mail@gmail.com> (Azat Khuzhin's message of "Tue, 10 Dec 2013 01:20:43 +0400") Message-ID: <87wqjc4dur.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-12/txt/msg00389.txt.bz2 >>>>> "Azat" == Azat Khuzhin writes: Azat> Display only non-common part of filename and compilation directory Azat> This will be useful for projects that use separate build directory Azat> inside project (like build/cmake and others). Thanks for doing this. Azat> 2013-12-00 Azat Khuzhin Azat> * source.h (symtab_to_shortpath): Add it. Azat> * source.c (filename_display): Add shortpath display. Azat> * (symtab_to_filename_for_display): Use symtab_to_shortpath. That final line doesn't need the "* ". Silly ChangeLogs. I think this patch needs at least a documentation patch and a NEWS entry. A test case would be nice, an addition to an existing test would be sufficient. Do you have copyright assignment paperwork in place? If not then please contact me off-list so I can get you started. Azat> +/* Returns only non-common part of filename and compilation directory. */ Azat> +extern const char *symtab_to_shortpath(struct symtab *symtab); Space before the open paren here. Tom