From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26489 invoked by alias); 10 Dec 2013 21:23:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26471 invoked by uid 89); 10 Dec 2013 21:23:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qe0-f49.google.com Received: from Unknown (HELO mail-qe0-f49.google.com) (209.85.128.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 10 Dec 2013 21:23:56 +0000 Received: by mail-qe0-f49.google.com with SMTP id w7so4582205qeb.22 for ; Tue, 10 Dec 2013 13:23:48 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.55.69 with SMTP id t5mr48728704qag.82.1386710628246; Tue, 10 Dec 2013 13:23:48 -0800 (PST) Received: by 10.96.175.66 with HTTP; Tue, 10 Dec 2013 13:23:48 -0800 (PST) In-Reply-To: <87wqjc4dur.fsf@fleche.redhat.com> References: <1386624043-11077-1-git-send-email-a3at.mail@gmail.com> <87wqjc4dur.fsf@fleche.redhat.com> Date: Tue, 10 Dec 2013 21:23:00 -0000 Message-ID: Subject: Re: [PATCH v5] gdb: set filename-display shortpath support From: Azat Khuzhin To: Tom Tromey Cc: gdb-patches@sourceware.org, Eli Zaretskii , Joel Brobecker , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2013-12/txt/msg00391.txt.bz2 On Wed, Dec 11, 2013 at 1:04 AM, Tom Tromey wrote: >>>>>> "Azat" == Azat Khuzhin writes: > > Azat> Display only non-common part of filename and compilation directory > Azat> This will be useful for projects that use separate build directory > Azat> inside project (like build/cmake and others). > > Thanks for doing this. > > Azat> 2013-12-00 Azat Khuzhin > Azat> * source.h (symtab_to_shortpath): Add it. > Azat> * source.c (filename_display): Add shortpath display. > Azat> * (symtab_to_filename_for_display): Use symtab_to_shortpath. > > That final line doesn't need the "* ". > Silly ChangeLogs. > > I think this patch needs at least a documentation patch and a NEWS > entry. Should I do this? If yes, into which file I must add this info? > > A test case would be nice, an addition to an existing test would be > sufficient. I will add it later. > > Do you have copyright assignment paperwork in place? Yes, I already sign it. > If not then please contact me off-list so I can get you started. > > Azat> +/* Returns only non-common part of filename and compilation directory. */ > Azat> +extern const char *symtab_to_shortpath(struct symtab *symtab); > > Space before the open paren here. Oh, sorry. Fixed in new patch. I will resent the patch with coding style fixes. Thanks! > > Tom -- Respectfully Azat Khuzhin