From: Jim Wilson <jimw@sifive.com>
To: "Maciej W. Rozycki" <macro@wdc.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Andrew Burgess <andrew.burgess@embecosm.com>,
Palmer Dabbelt <palmer@dabbelt.com>, Tom Tromey <tom@tromey.com>,
"guoren@kernel.org" <guoren@kernel.org>,
"lifang_xia@c-sky.com" <lifang_xia@c-sky.com>,
"yunhai_shang@c-sky.com" <yunhai_shang@c-sky.com>,
"jiangshuai_li@c-sky.com" <jiangshuai_li@c-sky.com>
Subject: Re: [PATCH v2 1/3] RISC-V/Linux/native: Determine FLEN dynamically
Date: Wed, 29 Jan 2020 23:26:00 -0000 [thread overview]
Message-ID: <CAFyWVabdTg3EQ7udO=tbvshjPaUTAgFCcgg7pn86kz0PqgcSVg@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.2001291410310.14118@redsun52.ssa.fujisawa.hgst.com>
On Wed, Jan 29, 2020 at 10:13 AM Maciej W. Rozycki <macro@wdc.com> wrote:
> gdb/
> * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
> (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
> offsets according to FLEN determined.
> (riscv_linux_nat_target::read_description): Determine FLEN
> dynamically.
> (riscv_linux_nat_target::fetch_registers): Size regset buffer
> according to FLEN determined.
> (riscv_linux_nat_target::store_registers): Likewise.
Looks OK to me, though I'm not an official reviewer.
I did notice a reference to FGR in a comment that should presumably be
FPR, but that is a very minor issue.
Jim
next prev parent reply other threads:[~2020-01-29 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.21.2001291207310.14118@redsun52.ssa.fujisawa.hgst.com>
2020-01-29 18:13 ` Maciej W. Rozycki
2020-01-29 23:26 ` Jim Wilson [this message]
2020-01-30 0:13 ` Maciej W. Rozycki
2020-01-30 23:19 ` Jim Wilson
2020-01-31 0:06 ` Andreas Schwab
2020-01-31 12:11 ` Maciej W. Rozycki
2020-01-29 18:14 ` [PATCH v2 2/3] RISC-V/Linux/native: Factor out target description determination Maciej W. Rozycki
2020-01-29 23:39 ` Jim Wilson
[not found] ` <alpine.LFD.2.21.2001291412560.14118@redsun52.ssa.fujisawa.hgst.com>
2020-01-30 0:00 ` [PATCH v2 3/3] gdbserver: Add RISC-V/Linux support Jim Wilson
2020-01-30 1:58 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyWVabdTg3EQ7udO=tbvshjPaUTAgFCcgg7pn86kz0PqgcSVg@mail.gmail.com' \
--to=jimw@sifive.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=guoren@kernel.org \
--cc=jiangshuai_li@c-sky.com \
--cc=lifang_xia@c-sky.com \
--cc=macro@wdc.com \
--cc=palmer@dabbelt.com \
--cc=tom@tromey.com \
--cc=yunhai_shang@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox