Re: [PATCH v2 3/3] gdbserver: Add RISC-V/Linux support

["Maciej W. Rozycki" <macro@wdc.com>]

On Wed, 29 Jan 2020, Jim Wilson wrote:

> I noticed on the gdbserver console I'm getting a lot of ptrace warnings.
>     ptrace(regsets_fetch_inferior_registers) PID=1678103: Invalid argument
>     Warning: ptrace(regsets_store_inferior_registers): Invalid argument
> This looks like a side effect of having two FP regsets defined, it
> tries the first one, fails, and then tries the second one which is
> correct.  If you mark them as OPTIONAL_REGS we would only get the
> warning once which would be OK, except that they can't be both FP_REGS
> and OPTIONAL_REGS at the same time.  I don't know what if anything
> would break if they aren't marked as FP_REGS.   I only see explicit
> checks for GENERAL_REGS and OPTIONAL_REGS; I don't see any checks for
> FP_REGS.  Anyways, I would suggest as a future improvement that the
> linux gdbserver regset support be extended so that a regset can be
> marked as both FP_REGS and OPTIONAL_REGS.

 Hmm, good point.  I think OPTIONAL_REGS might become a flag, however as 
you have observed there seems to be no special meaning indeed to FP_REGS 
and actually only a couple of `gdbserver' hosts use this type, so using 
OPTIONAL_REGS should be fine.  I'll send an update.

> There are some new functions and structures that don't have
> explanatory comments before them, but this is a minor issue.

 Right, though I think they are self-explanatory.

  Maciej