From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36011 invoked by alias); 29 Jan 2020 23:25:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35162 invoked by uid 89); 29 Jan 2020 23:25:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*RU:209.85.217.68, HX-Spam-Relays-External:209.85.217.68 X-HELO: mail-vs1-f68.google.com Received: from mail-vs1-f68.google.com (HELO mail-vs1-f68.google.com) (209.85.217.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Jan 2020 23:24:59 +0000 Received: by mail-vs1-f68.google.com with SMTP id b79so950339vsd.9 for ; Wed, 29 Jan 2020 15:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yQEPCu9HEUVJl/Efk7ua3QYH0vY7k6sW8OV1LmNzc6E=; b=LS6Cr58naGPbfZAzHf84XtKM625Y6D/NyyFq7A7lA3FjYX5mvSBCbmcYE2ctHk15PD WZrEfQRlf/T3rXZ1UhDu1FAR18nKAjTJpWUA0k7ewDEyK9btyuzgboa1zVhqdd5RsCkU WDgdL+Z8i50vt+iccVprSDXg/2ErDZNTLKt/3ljwIfZr3YjkWpTYxVMPONAfMc7KE9JK hzZMysSMGT/D74iHCohp+n5KuWY1f8e36GXa9FXFVdADuzMvXxURMVuYLcF+ikyN9FVP S7CFXIyBWnDzWBASVkADVup6VVZ8rZoWXGxWSN1GXo0NiOASK3w/4fy4AfZZwmboSr37 1NUA== MIME-Version: 1.0 References: In-Reply-To: From: Jim Wilson Date: Wed, 29 Jan 2020 23:26:00 -0000 Message-ID: Subject: Re: [PATCH v2 1/3] RISC-V/Linux/native: Determine FLEN dynamically To: "Maciej W. Rozycki" Cc: "gdb-patches@sourceware.org" , Andrew Burgess , Palmer Dabbelt , Tom Tromey , "guoren@kernel.org" , "lifang_xia@c-sky.com" , "yunhai_shang@c-sky.com" , "jiangshuai_li@c-sky.com" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00961.txt.bz2 On Wed, Jan 29, 2020 at 10:13 AM Maciej W. Rozycki wrote: > gdb/ > * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro. > (supply_fpregset_regnum, fill_fpregset): Handle regset buffer > offsets according to FLEN determined. > (riscv_linux_nat_target::read_description): Determine FLEN > dynamically. > (riscv_linux_nat_target::fetch_registers): Size regset buffer > according to FLEN determined. > (riscv_linux_nat_target::store_registers): Likewise. Looks OK to me, though I'm not an official reviewer. I did notice a reference to FGR in a comment that should presumably be FPR, but that is a very minor issue. Jim