From: Jim Wilson <jimw@sifive.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Thu Aug 9 01:56:05 UTC 2018
Date: Thu, 09 Aug 2018 16:45:00 -0000 [thread overview]
Message-ID: <CAFyWVaYx1cUeoA7N56RwiSmdGxAzdZ2EcxYQ9KoAJYEA-CdaQg@mail.gmail.com> (raw)
In-Reply-To: <87bmab8r8m.fsf@tromey.com>
On Thu, Aug 9, 2018 at 9:00 AM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes:
>
>>> 482a483
>>> gdb/riscv-tdep.h:84: code: function call in first column: Function
>>> name in first column should be restricted to function implementation
>>> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache);
>
> Here's a patch to fix a few minor formatting issues in riscv-tdep.h,
> including the one pointed out by ARI.
>
> Let me know what you think.
Yes, it looks good to me. I copied the function definition a little
too literally and forgot to reformat it for the header file.
I'm not familiar with ARI, I will have to read up on that.
Jim
prev parent reply other threads:[~2018-08-09 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 1:56 GDB Administrator
2018-08-09 16:01 ` Tom Tromey
2018-08-09 16:45 ` Jim Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaYx1cUeoA7N56RwiSmdGxAzdZ2EcxYQ9KoAJYEA-CdaQg@mail.gmail.com \
--to=jimw@sifive.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox