From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51434 invoked by alias); 9 Aug 2018 16:45:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51210 invoked by uid 89); 9 Aug 2018 16:45:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 16:45:19 +0000 Received: by mail-wm0-f52.google.com with SMTP id t25-v6so936235wmi.3 for ; Thu, 09 Aug 2018 09:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Bie7OI4xX00ObH1tpAuJYnhrX9V3l496VA/7Wqa5B2A=; b=YxYOvoDROi7RxMEZgcEJVFPu65/laa6iNw54AvOaohRaaI8R01aeeYgkj8eQZyu/PG 0NY3EXKZQTv4SKdFgIxG9QN9/1i8P5pfAuDwqmk/wtel+qIY3UPS3WNMc+m/cy3rIA2o aBOFFuoLh4bH7YMSaxIUpqgCHdfrC1rJ9Mudg1QFfiuzg9CrFjKM0s0TgR9/dmTGdOxc s1mB8jlC3hZCzrHFheihpv2wrbn6Y3DwSiVdW7R7tPsybvCFg8PG8MzayCvqscUGrZtH kZjh5+vW++XytRMAhKUm6GcoFxMfrggXq0pJ3PBL6m+er+jJ5zK5ZnVQ8KxdAUGutFoF tvUQ== MIME-Version: 1.0 Received: by 2002:adf:e44b:0:0:0:0:0 with HTTP; Thu, 9 Aug 2018 09:45:03 -0700 (PDT) In-Reply-To: <87bmab8r8m.fsf@tromey.com> References: <20180809015605.GA57522@sourceware.org> <87bmab8r8m.fsf@tromey.com> From: Jim Wilson Date: Thu, 09 Aug 2018 16:45:00 -0000 Message-ID: Subject: Re: New ARI warning Thu Aug 9 01:56:05 UTC 2018 To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-08/txt/msg00220.txt.bz2 On Thu, Aug 9, 2018 at 9:00 AM, Tom Tromey wrote: >>>>>> ">" == GDB Administrator writes: > >>> 482a483 >>> gdb/riscv-tdep.h:84: code: function call in first column: Function >>> name in first column should be restricted to function implementation >>> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache); > > Here's a patch to fix a few minor formatting issues in riscv-tdep.h, > including the one pointed out by ARI. > > Let me know what you think. Yes, it looks good to me. I copied the function definition a little too literally and forgot to reformat it for the header file. I'm not familiar with ARI, I will have to read up on that. Jim