Re: [PATCH] Add support for untagged unions

[Manish Goregaokar <manish@mozilla.com>]

Pushed all three patches. Thanks.
-Manish


On Thu, Nov 3, 2016 at 2:32 PM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:
>
> Re-CCing the list, I trust you don't mind.
>
> Manish> I haven't added inline union ctor expressions yet. They're similar to
> Manish> struct ctors but with only one field. Filed at
> Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20761 , might not get
> Manish> time to fix that for a bit.
>
> Thank you.
>
> Manish> I tried to fix the indentation, but I'm not really sure what the
> Manish> heuristic here is. Everything seems to use a mix of tabs followed by
> Manish> spaces, and I'm not sure how many of each to use. I have my tab width
> Manish> set to 2 and am using two tabs followed by however many spaces
> Manish> necessary to align it, but that might not be right. When pasting into
> Manish> gmail it seems like tabs automatically get converted to spaces.
>
> In the GNU style a tab is 8 spaces (really it moves to the next multiple
> of 8, but there should only be leading tabs).
>
> There's been occasional debate on just using spaces.
>
>
> This version looks ok to me.  Please check it in.
> If there's some lingering indentation issue I can fix it up later.
>
> Tom