Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Manish Goregaokar <manish@mozilla.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for untagged unions
Date: Thu, 03 Nov 2016 21:33:00 -0000	[thread overview]
Message-ID: <87oa1wl054.fsf@tromey.com> (raw)
In-Reply-To: <CAFOnWkkUibsZKsqFrwGv1kpJ52mNiDYCEEpc5utO1=LLh6W+XQ@mail.gmail.com>	(Manish Goregaokar's message of "Wed, 2 Nov 2016 10:16:26 -0700")

>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:

Re-CCing the list, I trust you don't mind.

Manish> I haven't added inline union ctor expressions yet. They're similar to
Manish> struct ctors but with only one field. Filed at
Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20761 , might not get
Manish> time to fix that for a bit.

Thank you.

Manish> I tried to fix the indentation, but I'm not really sure what the
Manish> heuristic here is. Everything seems to use a mix of tabs followed by
Manish> spaces, and I'm not sure how many of each to use. I have my tab width
Manish> set to 2 and am using two tabs followed by however many spaces
Manish> necessary to align it, but that might not be right. When pasting into
Manish> gmail it seems like tabs automatically get converted to spaces.

In the GNU style a tab is 8 spaces (really it moves to the next multiple
of 8, but there should only be leading tabs).

There's been occasional debate on just using spaces.


This version looks ok to me.  Please check it in.
If there's some lingering indentation issue I can fix it up later.

Tom


  parent reply	other threads:[~2016-11-03 21:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29  1:02 Manish Goregaokar
2016-10-29  1:07 ` Manish Goregaokar
2016-10-31  3:13 ` Tom Tromey
2016-10-31  3:42   ` Manish Goregaokar
     [not found]     ` <CAFOnWk=Fe7UrrN1dLgWhzmnmhUzPbAQPfyXGLNqHnnej_gdciw@mail.gmail.com>
     [not found]       ` <87bmxy7r8y.fsf@tromey.com>
     [not found]         ` <CAFOnWkkUibsZKsqFrwGv1kpJ52mNiDYCEEpc5utO1=LLh6W+XQ@mail.gmail.com>
2016-11-03 21:33           ` Tom Tromey [this message]
2016-11-03 22:47             ` Manish Goregaokar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa1wl054.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=manish@mozilla.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox