From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36529 invoked by alias); 3 Nov 2016 21:33:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36514 invoked by uid 89); 3 Nov 2016 21:33:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, unions, heuristic, H*F:U*tom X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 03 Nov 2016 21:33:01 +0000 Received: (qmail 17081 invoked by uid 0); 3 Nov 2016 21:32:59 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 3 Nov 2016 21:32:59 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 3ZYv1u00F2f2jeq01ZYy3D; Thu, 03 Nov 2016 15:32:58 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=BzObnAOqAAAA:8 a=CCpqsmhAAAAA:8 a=oI3sSg3JJmbblhcuoZMA:9 a=PuSIgb6VMkSJ0_1bSHE4:22 a=ul9cdbp4aOFLsgKbc677:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:34130 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c2Pd2-0003b0-Hq; Thu, 03 Nov 2016 15:32:56 -0600 From: Tom Tromey To: Manish Goregaokar Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for untagged unions References: <87shrdus79.fsf@tromey.com> <87bmxy7r8y.fsf@tromey.com> Date: Thu, 03 Nov 2016 21:33:00 -0000 In-Reply-To: (Manish Goregaokar's message of "Wed, 2 Nov 2016 10:16:26 -0700") Message-ID: <87oa1wl054.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c2Pd2-0003b0-Hq X-Source-Sender: 174-16-143-211.hlrn.qwest.net (pokyo) [174.16.143.211]:34130 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00074.txt.bz2 >>>>> "Manish" == Manish Goregaokar writes: Re-CCing the list, I trust you don't mind. Manish> I haven't added inline union ctor expressions yet. They're similar to Manish> struct ctors but with only one field. Filed at Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20761 , might not get Manish> time to fix that for a bit. Thank you. Manish> I tried to fix the indentation, but I'm not really sure what the Manish> heuristic here is. Everything seems to use a mix of tabs followed by Manish> spaces, and I'm not sure how many of each to use. I have my tab width Manish> set to 2 and am using two tabs followed by however many spaces Manish> necessary to align it, but that might not be right. When pasting into Manish> gmail it seems like tabs automatically get converted to spaces. In the GNU style a tab is 8 spaces (really it moves to the next multiple of 8, but there should only be leading tabs). There's been occasional debate on just using spaces. This version looks ok to me. Please check it in. If there's some lingering indentation issue I can fix it up later. Tom