From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113074 invoked by alias); 3 Nov 2016 22:47:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113064 invoked by uid 89); 3 Nov 2016 22:47:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=unions, Hx-languages-length:1317, heuristic X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 22:47:21 +0000 Received: by mail-wm0-f41.google.com with SMTP id n67so16114861wme.1 for ; Thu, 03 Nov 2016 15:47:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J0RV6TdTsVTx9HqucQNvr6qEQ9h80BwAEgRiACKXgYA=; b=jKPnJ1O/8c5PAyRkuv8jusHbeWK0MsGgzGyjkdRQSvwdF5JPB/RsW1wYSsYxFhr/be 1LTDkLsaB/yYC11aJuSGYHcDPTR1xW+nM0FO+Rcp4C9MXV4hKrO2djrA8LSeGMgoV1/M /bte3l2c0xrbXnLdx6xv5yH0fBZMeXvAioaFWLNChZVSZ3pE16RkW8OOQdy4vmuHsoIH WsGTXsSFRPK98ucMkrOv4spZtahyK0uIK9jDuKEcOf0r+3TJzGQLXYLBF/8c7ZZLTomK GSj5hOoBzScc5ehB0SDez4NkDfl0NBsIsowrtTvtsutX9fAyXv4gWqAyGRHnMYZLpiO2 8PPQ== X-Gm-Message-State: ABUngvfuXTLvK91H144qg1w+KocN/RgsdOviCQprKuH17z1K8SXcXnmOZNjI5Dj5237iP8jYinujxd34FaUvVWFh X-Received: by 10.28.113.18 with SMTP id m18mr245936wmc.101.1478213238990; Thu, 03 Nov 2016 15:47:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.234.200 with HTTP; Thu, 3 Nov 2016 15:46:58 -0700 (PDT) In-Reply-To: <87oa1wl054.fsf@tromey.com> References: <87shrdus79.fsf@tromey.com> <87bmxy7r8y.fsf@tromey.com> <87oa1wl054.fsf@tromey.com> From: Manish Goregaokar Date: Thu, 03 Nov 2016 22:47:00 -0000 Message-ID: Subject: Re: [PATCH] Add support for untagged unions To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00075.txt.bz2 Pushed all three patches. Thanks. -Manish On Thu, Nov 3, 2016 at 2:32 PM, Tom Tromey wrote: >>>>>> "Manish" == Manish Goregaokar writes: > > Re-CCing the list, I trust you don't mind. > > Manish> I haven't added inline union ctor expressions yet. They're similar to > Manish> struct ctors but with only one field. Filed at > Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20761 , might not get > Manish> time to fix that for a bit. > > Thank you. > > Manish> I tried to fix the indentation, but I'm not really sure what the > Manish> heuristic here is. Everything seems to use a mix of tabs followed by > Manish> spaces, and I'm not sure how many of each to use. I have my tab width > Manish> set to 2 and am using two tabs followed by however many spaces > Manish> necessary to align it, but that might not be right. When pasting into > Manish> gmail it seems like tabs automatically get converted to spaces. > > In the GNU style a tab is 8 spaces (really it moves to the next multiple > of 8, but there should only be leading tabs). > > There's been occasional debate on just using spaces. > > > This version looks ok to me. Please check it in. > If there's some lingering indentation issue I can fix it up later. > > Tom