Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,
	Sergio Durigan Junior <sergiodj@redhat.com>,
		Doug Evans <dje@sebabeach.org>,
	gdb-patches@sourceware.org
Subject: Re: [patch] Create cleanups.[ch]
Date: Tue, 17 Apr 2012 22:41:00 -0000	[thread overview]
Message-ID: <CADPb22TyzrOPggZrHiRbS4icSVBcM+D7oVo+5X09r7Kxqyh-pQ@mail.gmail.com> (raw)
In-Reply-To: <87wr5fxvbk.fsf@fleche.redhat.com>

On Mon, Apr 16, 2012 at 1:42 PM, Tom Tromey <tromey@redhat.com> wrote:
> Pedro> I only meant that it'd have preferred such change as a separate change.
>
> Yeah, me too.
>
> Tom

Making it a separate change meant splitting it into three patches instead of one
(unless I either artificially made cleanup_chain non-static for one
patch, blech, or modified the remaining uses in utils.c to not
reference it, but then it would still be more than just a simple
move).  That is why I went that route this time.

But whatever, three patches checked in (after a whole pile of extra effort).

One to go.


  reply	other threads:[~2012-04-17 21:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 20:27 Doug Evans
2012-04-16  7:27 ` Sergio Durigan Junior
2012-04-16 10:52   ` Pedro Alves
2012-04-16 19:11     ` Sergio Durigan Junior
2012-04-18  9:43       ` Pedro Alves
2012-04-19 17:37         ` Sergio Durigan Junior
2012-04-20 15:09           ` Pedro Alves
2012-04-16 20:06     ` Tom Tromey
2012-04-16 20:42       ` Pedro Alves
2012-04-16 20:59         ` Tom Tromey
2012-04-17 22:41           ` Doug Evans [this message]
2012-04-16 20:10   ` Tom Tromey
2012-04-17 22:54   ` Doug Evans
2012-04-17 22:59     ` Joel Brobecker
2012-04-18  4:26       ` Sergio Durigan Junior
2012-04-18  6:22         ` Joel Brobecker
2012-04-16 10:40 ` Pedro Alves
2012-04-18 14:02 ` Yao Qi
2012-04-18 14:32   ` Tom Tromey
2012-04-16  2:07 Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22TyzrOPggZrHiRbS4icSVBcM+D7oVo+5X09r7Kxqyh-pQ@mail.gmail.com \
    --to=dje@google.com \
    --cc=dje@sebabeach.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sergiodj@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox