From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
Doug Evans <dje@sebabeach.org>,
gdb-patches@sourceware.org
Subject: Re: [patch] Create cleanups.[ch]
Date: Mon, 16 Apr 2012 20:06:00 -0000 [thread overview]
Message-ID: <87r4vnzbkl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F8BF983.2090204@redhat.com> (Pedro Alves's message of "Mon, 16 Apr 2012 11:50:43 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This made me notice that make_my_cleanup was unexported, and made
Pedro> static in this patch, but note how that goes by mostly unnoticed
Pedro> (at least it was to me on first sight).
I have long had the impression, based solely on reading the cleanup
code, that cleanups were intended to be used in other ways and then
never were. E.g., unchaining cleanups and attaching them to some other
object (say, replacing the existing objfile data destructor methods)
seems doable, but AFAIK is not ever done.
If anything is unused at this point, I'd say we can just delete it.
Tom
next prev parent reply other threads:[~2012-04-16 20:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 20:27 Doug Evans
2012-04-16 7:27 ` Sergio Durigan Junior
2012-04-16 10:52 ` Pedro Alves
2012-04-16 19:11 ` Sergio Durigan Junior
2012-04-18 9:43 ` Pedro Alves
2012-04-19 17:37 ` Sergio Durigan Junior
2012-04-20 15:09 ` Pedro Alves
2012-04-16 20:06 ` Tom Tromey [this message]
2012-04-16 20:42 ` Pedro Alves
2012-04-16 20:59 ` Tom Tromey
2012-04-17 22:41 ` Doug Evans
2012-04-16 20:10 ` Tom Tromey
2012-04-17 22:54 ` Doug Evans
2012-04-17 22:59 ` Joel Brobecker
2012-04-18 4:26 ` Sergio Durigan Junior
2012-04-18 6:22 ` Joel Brobecker
2012-04-16 10:40 ` Pedro Alves
2012-04-18 14:02 ` Yao Qi
2012-04-18 14:32 ` Tom Tromey
2012-04-16 2:07 Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4vnzbkl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@sebabeach.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox