From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 418 invoked by alias); 16 Apr 2012 20:06:25 -0000 Received: (qmail 409 invoked by uid 22791); 16 Apr 2012 20:06:25 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 20:06:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3GK63kc002409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Apr 2012 16:06:05 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3GK62X6032600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Apr 2012 16:06:03 -0400 From: Tom Tromey To: Pedro Alves Cc: Sergio Durigan Junior , Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] Create cleanups.[ch] References: <4F8BF983.2090204@redhat.com> Date: Mon, 16 Apr 2012 20:06:00 -0000 In-Reply-To: <4F8BF983.2090204@redhat.com> (Pedro Alves's message of "Mon, 16 Apr 2012 11:50:43 +0100") Message-ID: <87r4vnzbkl.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00431.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This made me notice that make_my_cleanup was unexported, and made Pedro> static in this patch, but note how that goes by mostly unnoticed Pedro> (at least it was to me on first sight). I have long had the impression, based solely on reading the cleanup code, that cleanups were intended to be used in other ways and then never were. E.g., unchaining cleanups and attaching them to some other object (say, replacing the existing objfile data destructor methods) seems doable, but AFAIK is not ever done. If anything is unused at this point, I'd say we can just delete it. Tom