From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28331 invoked by alias); 17 Apr 2012 21:33:01 -0000 Received: (qmail 28321 invoked by uid 22791); 17 Apr 2012 21:33:00 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 21:32:46 +0000 Received: by vbbey12 with SMTP id ey12so5541813vbb.0 for ; Tue, 17 Apr 2012 14:32:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=6IdX4zkf7oWvUKjq6TXq+djmIpSWlbFnE53QvrEN2Xs=; b=IPV5Ah6Dx3ofIyjCrZxqc/PjmIATqIzxmp7FLzyCidWPR1RJjJ8sA9La21ONsH2AFB qlo+nCT1xVkliEnv9gSG53osY1ucU43yCYY8qjl1Eu6a/xWHPyR03iLrr8fc40htaMoY f+kaldUNyR5sp3GJFLcWAelJHZDUm8TQa/x2/ekmaB/DH3AJjofAsObfZra9WGBviDSH z1R1iCKnnQb7n+u8X9qbt5IWjVy1uHcbK+pdl8wYLsLUV5gbHxpiElYNyS1MdjcN/msD hJTJ7J94kr9tCk8aqlozahr1MKcv3Oww1eZ2z4X2d9oOG4JNCYAxshIJcMGumzja+haN qJbQ== Received: by 10.220.188.12 with SMTP id cy12mr4170832vcb.69.1334698365276; Tue, 17 Apr 2012 14:32:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.188.12 with SMTP id cy12mr4170813vcb.69.1334698364894; Tue, 17 Apr 2012 14:32:44 -0700 (PDT) Received: by 10.220.115.78 with HTTP; Tue, 17 Apr 2012 14:32:44 -0700 (PDT) In-Reply-To: <87wr5fxvbk.fsf@fleche.redhat.com> References: <4F8BF983.2090204@redhat.com> <87r4vnzbkl.fsf@fleche.redhat.com> <4F8C83D4.7050807@redhat.com> <87wr5fxvbk.fsf@fleche.redhat.com> Date: Tue, 17 Apr 2012 22:41:00 -0000 Message-ID: Subject: Re: [patch] Create cleanups.[ch] From: Doug Evans To: Tom Tromey Cc: Pedro Alves , Sergio Durigan Junior , Doug Evans , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQkTtvxs/2sr+yuvqzQlbXDQQuSqA2YPRh2eEMtgCoqxZNiC5mDyCueuKCkR/38OOAM18PkoiJCt684EMspXEPqZcMSAsIqA76Ud/ilOoaurp9qaxq5wexGxA574arvAz88BuiuVTFHoJlmCqI5QHI2cH7pHfQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00519.txt.bz2 On Mon, Apr 16, 2012 at 1:42 PM, Tom Tromey wrote: > Pedro> I only meant that it'd have preferred such change as a separate change. > > Yeah, me too. > > Tom Making it a separate change meant splitting it into three patches instead of one (unless I either artificially made cleanup_chain non-static for one patch, blech, or modified the remaining uses in utils.c to not reference it, but then it would still be more than just a simple move). That is why I went that route this time. But whatever, three patches checked in (after a whole pile of extra effort). One to go.