From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 03/10] Move target-dcache out of target.c
Date: Sun, 17 Nov 2013 20:15:00 -0000 [thread overview]
Message-ID: <CADPb22TvCyO2coLto6xHHT2eUYrhBeb1tg9k27XTNRKjuNcJjw@mail.gmail.com> (raw)
In-Reply-To: <1383458049-20893-4-git-send-email-yao@codesourcery.com>
On Sat, Nov 2, 2013 at 10:54 PM, Yao Qi <yao@codesourcery.com> wrote:
> This patch moves target_dcache related code out of target.c.
>
> gdb:
>
> 2013-11-02 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (SFILES):Add target-dcache.c.
> (HFILES_NO_SRCDIR): Add target-dcache.h.
> (COMMON_OBS): Add target-dcache.o.
> * dcache.c: Remove inclusion to "target.h". Include
> "target-dcache.h".
> * memattr.c: Include "target-dcache.h".
> * top.c: Likewise.
> * tracepoint.c: Likewise.
> * target.c: (stack_cache_enabled_p_1): Move to
> target-dcache.c.
> (stack_cache_enabled_p): Likewise.
> (set_stack_cache_enabled_p): Likewise.
> (show_stack_cache_enabled_p): Likewise.
> (target_dcache, target_dcache_init_p): Likewise.
> (target_dcache_invalidate): Likewise.
> (target_dcache_get, target_dcache_get_or_init): Likewise.
> (memory_xfer_partial_1): Call function stack_cache_enabled.
> (initialize_target): Move code to target-dcache.c.
> * target.h (target_dcache_invalidate): Move to
> target-dcache.h.
> (target_dcache_get): Likewise.
> * target-dcache.c: New.
> * target-dcahce.h: New.
Typo in changelog entry for target-dcache.h.
Plus target-dcache.h needs #ifndef TARGET_DCACHE_H/etc.
Ok with those changes.
[For a later cleanup I would rename stack_cache_enabled() to
stack_cache_enabled_p(), and rename the underlying variables of
course. I wouldn't do that in this patch of course since it's good to
keep the moving of code in a patch onto itself.]
next prev parent reply other threads:[~2013-11-17 20:09 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 5:57 [PATCH 00/10 V2] Cache code access for disassemble Yao Qi
2013-11-03 5:56 ` [PATCH 01/10] Remove last_cache Yao Qi
2013-11-17 19:52 ` Doug Evans
2013-11-03 5:56 ` [PATCH 08/10] Don't invalidate dcache when option stack-cache is changed Yao Qi
2013-11-17 22:02 ` Doug Evans
2013-11-18 14:12 ` Yao Qi
2013-11-18 15:51 ` Pedro Alves
2013-11-19 6:43 ` Yao Qi
2013-11-19 12:14 ` Pedro Alves
2013-11-19 14:06 ` Yao Qi
2013-11-03 5:56 ` [PATCH 09/10] set/show code-cache Yao Qi
2013-11-03 16:58 ` Eli Zaretskii
2013-11-18 8:23 ` Doug Evans
2013-11-03 5:56 ` [PATCH 03/10] Move target-dcache out of target.c Yao Qi
2013-11-17 20:15 ` Doug Evans [this message]
2013-11-18 15:53 ` Pedro Alves
2013-11-03 5:56 ` [PATCH 05/10] Invalidate or shrink dcache when setting is changed Yao Qi
2013-11-03 16:50 ` Eli Zaretskii
2013-11-17 20:55 ` Doug Evans
2013-11-18 14:31 ` Yao Qi
2013-11-18 15:59 ` Pedro Alves
2013-11-19 6:16 ` Yao Qi
2013-11-19 11:52 ` Pedro Alves
2013-11-19 13:12 ` Yao Qi
2013-11-03 5:56 ` [PATCH 07/10] Associate target_dcache to address_space Yao Qi
2013-11-03 16:48 ` Eli Zaretskii
2013-11-17 21:22 ` Doug Evans
2013-11-20 7:54 ` Yao Qi
2013-11-20 13:23 ` Yao Qi
2013-11-03 5:56 ` [PATCH 02/10] Don't update target_dcache if it is not initialized Yao Qi
2013-11-17 20:09 ` Doug Evans
2013-11-03 5:57 ` [PATCH 06/10] Add REGISTRY for struct address_space Yao Qi
2013-11-17 21:09 ` Doug Evans
2013-11-20 4:46 ` Yao Qi
2013-11-03 5:57 ` [PATCH 04/10] Don't stress 'remote' in "Data Caching" in doc Yao Qi
2013-11-03 16:55 ` Eli Zaretskii
2013-11-06 7:56 ` Yao Qi
2013-11-06 10:28 ` Eli Zaretskii
2013-11-17 20:34 ` Doug Evans
2013-11-17 21:44 ` Eli Zaretskii
2013-11-20 2:41 ` Doug Evans
2013-11-20 4:01 ` Eli Zaretskii
2013-11-22 1:17 ` Doug Evans
2013-11-20 3:58 ` Yao Qi
2013-11-11 9:38 ` [PATCH 00/10 V2] Cache code access for disassemble Yao Qi
2013-11-17 17:03 ` Yao Qi
2013-11-18 8:39 ` [PATCH 10/10] Use target_read_code in disassemble Yao Qi
2013-11-18 17:12 ` Doug Evans
2013-11-20 4:46 ` [PATCH 00/10 V2] Cache code access for disassemble Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TvCyO2coLto6xHHT2eUYrhBeb1tg9k27XTNRKjuNcJjw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox