From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 00/10 V2] Cache code access for disassemble
Date: Sun, 03 Nov 2013 05:57:00 -0000 [thread overview]
Message-ID: <1383458049-20893-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
This is the V2 of this patch series. In the discussion of V1, the
major comments are:
1. dcache.c and target_dcache needs some cleanups and factor.
2. commands "set dcache size" and "set dcahce line-size" needs a
description on semantics when dcache is per-address_space.
3. Use a single global 'target_dcache' for both stack caching and
code caching.
4. Replace "executable code" with "code segment" in doc and NEWS.
V2 addresses these comments as follows:
Patch #1 ~ #4 are about cleanups and factors to dcache.c and
target_dcache. Patch #5 is a minor optimization to target_dcache.
Patch #6 and #7 change target_dcache to per-address_space mode, and
update doc on dcache-related commands.
We decide to use single 'target_dcache' for caching different types
of access, so cache invalidation caused by option "stack-cache"
changes makes troubles. Think a little, I find we don't have to
invalidate target_dcache when option "stack-cache" is changed. This
is what patch #8 does, and looks change in patch #8 doesn't affect
the semantics of option "set stack-cache".
Patch #9 adds command "set code-cache", similar to "set stack-cache", and
patch #10 is to use TARGET_OBJECT_CODE_MEMORY to read for disassembly.
Patch 4, 5, 7, and 9 need doc review.
Each patch is regression tested on x86_64-linux.
*** BLURB HERE ***
Yao Qi (10):
Remove last_cache
Don't update target_dcache if it is not initialized
Move target-dcache out of target.c
Don't stress 'remote' in "Data Caching" in doc
Invalidate or shrink dcache when setting is changed.
Add REGISTRY for struct address_space.
Associate target_dcache to address_space.
Don't invalidate dcache when option stack-cache is changed
set/show code-cache
Use target_read_code in disassemble.
gdb/Makefile.in | 6 +-
gdb/NEWS | 6 ++
gdb/dcache.c | 93 ++++++++++++++++++---------
gdb/dcache.h | 4 +
gdb/disasm.c | 2 +-
gdb/doc/gdb.texinfo | 52 ++++++++++-----
gdb/memattr.c | 1 +
gdb/progspace.c | 14 ++---
gdb/progspace.h | 19 +++++-
gdb/target-dcache.c | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++
gdb/target-dcache.h | 30 +++++++++
gdb/target.c | 94 +++++++++-------------------
gdb/target.h | 9 ++-
gdb/top.c | 1 +
gdb/tracepoint.c | 1 +
15 files changed, 379 insertions(+), 128 deletions(-)
create mode 100644 gdb/target-dcache.c
create mode 100644 gdb/target-dcache.h
--
1.7.7.6
next reply other threads:[~2013-11-03 5:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 5:57 Yao Qi [this message]
2013-11-03 5:56 ` [PATCH 02/10] Don't update target_dcache if it is not initialized Yao Qi
2013-11-17 20:09 ` Doug Evans
2013-11-03 5:56 ` [PATCH 07/10] Associate target_dcache to address_space Yao Qi
2013-11-03 16:48 ` Eli Zaretskii
2013-11-17 21:22 ` Doug Evans
2013-11-20 7:54 ` Yao Qi
2013-11-20 13:23 ` Yao Qi
2013-11-03 5:56 ` [PATCH 05/10] Invalidate or shrink dcache when setting is changed Yao Qi
2013-11-03 16:50 ` Eli Zaretskii
2013-11-17 20:55 ` Doug Evans
2013-11-18 14:31 ` Yao Qi
2013-11-18 15:59 ` Pedro Alves
2013-11-19 6:16 ` Yao Qi
2013-11-19 11:52 ` Pedro Alves
2013-11-19 13:12 ` Yao Qi
2013-11-03 5:56 ` [PATCH 03/10] Move target-dcache out of target.c Yao Qi
2013-11-17 20:15 ` Doug Evans
2013-11-18 15:53 ` Pedro Alves
2013-11-03 5:56 ` [PATCH 09/10] set/show code-cache Yao Qi
2013-11-03 16:58 ` Eli Zaretskii
2013-11-18 8:23 ` Doug Evans
2013-11-03 5:56 ` [PATCH 08/10] Don't invalidate dcache when option stack-cache is changed Yao Qi
2013-11-17 22:02 ` Doug Evans
2013-11-18 14:12 ` Yao Qi
2013-11-18 15:51 ` Pedro Alves
2013-11-19 6:43 ` Yao Qi
2013-11-19 12:14 ` Pedro Alves
2013-11-19 14:06 ` Yao Qi
2013-11-03 5:56 ` [PATCH 01/10] Remove last_cache Yao Qi
2013-11-17 19:52 ` Doug Evans
2013-11-03 5:57 ` [PATCH 04/10] Don't stress 'remote' in "Data Caching" in doc Yao Qi
2013-11-03 16:55 ` Eli Zaretskii
2013-11-06 7:56 ` Yao Qi
2013-11-06 10:28 ` Eli Zaretskii
2013-11-17 20:34 ` Doug Evans
2013-11-17 21:44 ` Eli Zaretskii
2013-11-20 2:41 ` Doug Evans
2013-11-20 4:01 ` Eli Zaretskii
2013-11-22 1:17 ` Doug Evans
2013-11-20 3:58 ` Yao Qi
2013-11-03 5:57 ` [PATCH 06/10] Add REGISTRY for struct address_space Yao Qi
2013-11-17 21:09 ` Doug Evans
2013-11-20 4:46 ` Yao Qi
2013-11-11 9:38 ` [PATCH 00/10 V2] Cache code access for disassemble Yao Qi
2013-11-17 17:03 ` Yao Qi
2013-11-18 8:39 ` [PATCH 10/10] Use target_read_code in disassemble Yao Qi
2013-11-18 17:12 ` Doug Evans
2013-11-20 4:46 ` [PATCH 00/10 V2] Cache code access for disassemble Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383458049-20893-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox