From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32256 invoked by alias); 17 Nov 2013 20:09:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32246 invoked by uid 89); 17 Nov 2013 20:09:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-vb0-f48.google.com Received: from Unknown (HELO mail-vb0-f48.google.com) (209.85.212.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 17 Nov 2013 20:09:16 +0000 Received: by mail-vb0-f48.google.com with SMTP id m10so4018080vbh.7 for ; Sun, 17 Nov 2013 12:09:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9Ah3Hl2VNiTzca/auB0zH7V8scKqIeXNmtp7gaa02ac=; b=Hi3KEpBKsUlpluRiNeyouy6hmlgYnDx41fe0jdJStGZhbPwPnS6vEjWJnVL6reIQGb l6UinsFAOZ8iIDQPz9frj5WDbvljfAAjqge+zxVcBjyRjFZ+189KIiQnsD9dDxIlc38/ M0Lyv6fByGVN+a8fuLC2mG369zn1CgLxYZ/8cZwtd4MNvkLqNujoRdt0y/T0aMFc6Zuz T7v3lL2SJO9g5nOdszgW2mv2JjwzLs9LrcIFzD74mF13Hlx2QRVvOTnvwHhTJJFJs3IN PIbzRDcwpswH5Nsi5vdU8pEfrqzBBotQuPWjErk7qba1dkfTvSAI8wh4rAyzPTnkwia6 65Jg== X-Gm-Message-State: ALoCoQkAsPfFd48pwkKj9JdVjeJUlDlJRwNIYxlstrsVMB3l/Ei+obyqbmdN/pHtv3E9UfdrXP0sQr7/7Zgy9ANB9CwaqIqeIswicnwhetkKqKwRNPu/Bka9m2d5gXrXIrCfZS4d/QBHVuEB5DK++zidDTWRkfdq0NStsWVKIN4XZ0HFS4ihZBFuNTmXpB/Dy/gn4XYSj7pi0flXPSd278O/VUbrNjDxjQ== MIME-Version: 1.0 X-Received: by 10.58.39.97 with SMTP id o1mr11791596vek.15.1384718947730; Sun, 17 Nov 2013 12:09:07 -0800 (PST) Received: by 10.52.163.52 with HTTP; Sun, 17 Nov 2013 12:09:07 -0800 (PST) In-Reply-To: <1383458049-20893-4-git-send-email-yao@codesourcery.com> References: <1383458049-20893-1-git-send-email-yao@codesourcery.com> <1383458049-20893-4-git-send-email-yao@codesourcery.com> Date: Sun, 17 Nov 2013 20:15:00 -0000 Message-ID: Subject: Re: [PATCH 03/10] Move target-dcache out of target.c From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00447.txt.bz2 On Sat, Nov 2, 2013 at 10:54 PM, Yao Qi wrote: > This patch moves target_dcache related code out of target.c. > > gdb: > > 2013-11-02 Yao Qi > > * Makefile.in (SFILES):Add target-dcache.c. > (HFILES_NO_SRCDIR): Add target-dcache.h. > (COMMON_OBS): Add target-dcache.o. > * dcache.c: Remove inclusion to "target.h". Include > "target-dcache.h". > * memattr.c: Include "target-dcache.h". > * top.c: Likewise. > * tracepoint.c: Likewise. > * target.c: (stack_cache_enabled_p_1): Move to > target-dcache.c. > (stack_cache_enabled_p): Likewise. > (set_stack_cache_enabled_p): Likewise. > (show_stack_cache_enabled_p): Likewise. > (target_dcache, target_dcache_init_p): Likewise. > (target_dcache_invalidate): Likewise. > (target_dcache_get, target_dcache_get_or_init): Likewise. > (memory_xfer_partial_1): Call function stack_cache_enabled. > (initialize_target): Move code to target-dcache.c. > * target.h (target_dcache_invalidate): Move to > target-dcache.h. > (target_dcache_get): Likewise. > * target-dcache.c: New. > * target-dcahce.h: New. Typo in changelog entry for target-dcache.h. Plus target-dcache.h needs #ifndef TARGET_DCACHE_H/etc. Ok with those changes. [For a later cleanup I would rename stack_cache_enabled() to stack_cache_enabled_p(), and rename the underlying variables of course. I wouldn't do that in this patch of course since it's good to keep the moving of code in a patch onto itself.]