From: Doug Evans <dje@google.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: New frame_cache_cleared observer.
Date: Wed, 25 Mar 2015 23:18:00 -0000 [thread overview]
Message-ID: <CADPb22TsxSy8d8dstV5HPz6gU-Nbf=sKoyVXFHcR5VNTdXB3Zg@mail.gmail.com> (raw)
In-Reply-To: <1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com>
On Wed, Mar 25, 2015 at 10:11 AM, Andrew Burgess
<andrew.burgess@embecosm.com> wrote:
> This adds a new observer for the frame cache cleared event.
>
> While working on a new gdb port I found that I wanted to cache machine
> state that was gathered as part of the register read process. The
> most appropriate time to discard this cached information is when the
> frame cache is flushed.
>
> However, as I don't have an actual use for this observer that I can
> post upstream (yet) I don't know if this will be acceptable, but given
> it's a fairly small change I thought I'd try.
>
> OK to apply?
>
> Thanks,
> Andrew
>
> ---
> This adds a new frame_cache_cleared observer.
>
> gdb/ChangeLog:
>
> * frame.c (reinit_frame_cache): Trigger frame_cache_cleared
> observers.
Hi.
AIUI, our rules for dead code elimination preclude such a patch being applied.
I can go either way on this particular patch myself, but those are the rules
(as I understand them).
next prev parent reply other threads:[~2015-03-25 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 17:11 Andrew Burgess
2015-03-25 23:18 ` Doug Evans [this message]
2015-03-26 9:24 ` Pedro Alves
2015-03-26 12:50 ` Andrew Burgess
2015-03-30 18:51 ` Doug Evans
2015-03-31 12:08 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TsxSy8d8dstV5HPz6gU-Nbf=sKoyVXFHcR5VNTdXB3Zg@mail.gmail.com' \
--to=dje@google.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox