From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH] gdb: New frame_cache_cleared observer.
Date: Wed, 25 Mar 2015 17:11:00 -0000 [thread overview]
Message-ID: <1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com> (raw)
This adds a new observer for the frame cache cleared event.
While working on a new gdb port I found that I wanted to cache machine
state that was gathered as part of the register read process. The
most appropriate time to discard this cached information is when the
frame cache is flushed.
However, as I don't have an actual use for this observer that I can
post upstream (yet) I don't know if this will be acceptable, but given
it's a fairly small change I thought I'd try.
OK to apply?
Thanks,
Andrew
---
This adds a new frame_cache_cleared observer.
gdb/ChangeLog:
* frame.c (reinit_frame_cache): Trigger frame_cache_cleared
observers.
gdb/doc/ChangeLog:
* observer.texi (frame_cache_cleared): New event.
---
gdb/ChangeLog | 5 +++++
gdb/doc/ChangeLog | 4 ++++
gdb/doc/observer.texi | 4 ++++
gdb/frame.c | 3 +++
4 files changed, 16 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index febc377..6d5c757 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-25 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * frame.c (reinit_frame_cache): Trigger frame_cache_cleared
+ observers.
+
2015-03-25 Pedro Alves <palves@redhat.com>
* target.h <to_async>: Replace 'callback' and 'context' parameters
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 30d5a5b..b801f0c 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-25 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * observer.texi (frame_cache_cleared): New event.
+
2015-03-24 Pedro Alves <palves@redhat.com>
* gdb.texinfo (test_step) <set scheduler-locking step>: No longer
diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi
index fc3c74a..f33ecb4 100644
--- a/gdb/doc/observer.texi
+++ b/gdb/doc/observer.texi
@@ -122,6 +122,10 @@ A synchronous command finished.
An error was caught while executing a command.
@end deftypefun
+@deftypefun void frame_cache_cleared (void)
+The inferior has had its frame cached cleared.
+@end deftypefun
+
@deftypefun void target_changed (struct target_ops *@var{target})
The target's register contents have changed.
@end deftypefun
diff --git a/gdb/frame.c b/gdb/frame.c
index b3cbf23..94e4f75 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1690,6 +1690,9 @@ reinit_frame_cache (void)
{
struct frame_info *fi;
+ /* Announce cache clearance before releasing memory. */
+ observer_notify_frame_cache_cleared ();
+
/* Tear down all frame caches. */
for (fi = current_frame; fi != NULL; fi = fi->prev)
{
--
2.2.2
next reply other threads:[~2015-03-25 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 17:11 Andrew Burgess [this message]
2015-03-25 23:18 ` Doug Evans
2015-03-26 9:24 ` Pedro Alves
2015-03-26 12:50 ` Andrew Burgess
2015-03-30 18:51 ` Doug Evans
2015-03-31 12:08 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox