From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77801 invoked by alias); 25 Mar 2015 23:18:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77791 invoked by uid 89); 25 Mar 2015 23:18:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Mar 2015 23:18:49 +0000 Received: by oier21 with SMTP id r21so35416823oie.1 for ; Wed, 25 Mar 2015 16:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sGgJkvYcYb5B6TNXD0buMM49uUa8Qcq39VOkzkddDAI=; b=MEYp3wssdce7Ixai9IGZ1fgmkvNHKlaBVZB6gLp4pj/fHsqmp/dYTH3YEb0G4+JbDV zcv+dAQu/jaBRDAbZJ76zw26ZVJPGPLl8lHO4/PnI4KqgtV3aJzD1TOG2RDocEguykdI Qg1yRhkgV8KCCbX7t0v5dUdvpoZzx1c3vHaatPhOMf5SAsF/fAJUMoTl4ht3X+xQEFt3 DuSVxz2x10tkaCGP2s3josAB0FVjuOqUCdVQALfRd8fV0LXpN4DjhWQHKyfPwM4ggHI0 V0b0Ep7ba1ontoFjh2QGejeMQgT8Ic8gJInggCBaSuWEM6eyvTgJAz21gEbyypD/TH22 PAoQ== X-Gm-Message-State: ALoCoQksoDVJIIV+JP8GRAFiQPhew1J3ZFEmKPZAxgkFB5FRrRFQaGDKiVdIYmdMskRiMJBNMm47 MIME-Version: 1.0 X-Received: by 10.202.185.139 with SMTP id j133mr9237879oif.72.1427325528006; Wed, 25 Mar 2015 16:18:48 -0700 (PDT) Received: by 10.182.142.226 with HTTP; Wed, 25 Mar 2015 16:18:47 -0700 (PDT) In-Reply-To: <1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com> References: <1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com> Date: Wed, 25 Mar 2015 23:18:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: New frame_cache_cleared observer. From: Doug Evans To: Andrew Burgess Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00838.txt.bz2 On Wed, Mar 25, 2015 at 10:11 AM, Andrew Burgess wrote: > This adds a new observer for the frame cache cleared event. > > While working on a new gdb port I found that I wanted to cache machine > state that was gathered as part of the register read process. The > most appropriate time to discard this cached information is when the > frame cache is flushed. > > However, as I don't have an actual use for this observer that I can > post upstream (yet) I don't know if this will be acceptable, but given > it's a fairly small change I thought I'd try. > > OK to apply? > > Thanks, > Andrew > > --- > This adds a new frame_cache_cleared observer. > > gdb/ChangeLog: > > * frame.c (reinit_frame_cache): Trigger frame_cache_cleared > observers. Hi. AIUI, our rules for dead code elimination preclude such a patch being applied. I can go either way on this particular patch myself, but those are the rules (as I understand them).