From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
Date: Wed, 05 Jun 2013 21:28:00 -0000 [thread overview]
Message-ID: <CADPb22TsiiaNfY1yqRyNhCe8O-d2Ld6oYUkehk4zz1i3CzspOA@mail.gmail.com> (raw)
In-Reply-To: <51A0D2EC.80209@redhat.com>
On Sat, May 25, 2013 at 8:04 AM, Pedro Alves <palves@redhat.com> wrote:
> Fun. Thanks for the detailed analysis.
>
> On 05/25/2013 02:25 AM, Doug Evans wrote:
>
>> - *(int *)base = desc[1];
>> + /* Ensure we properly extend the value to 64-bits for x86_64. */
>> + *base = (void*) (uintptr_t) desc[1];
>
> missing space: 'void *'.
>
> Otherwise OK.
>
> Thanks,
> --
> Pedro Alves
Patch committed to 7.6 branch as well (and 7.6 wiki updated).
next prev parent reply other threads:[~2013-06-05 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 1:25 Doug Evans
2013-05-25 15:04 ` Pedro Alves
2013-06-05 21:28 ` Doug Evans [this message]
2013-06-06 5:20 ` Joel Brobecker
2013-06-06 18:00 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TsiiaNfY1yqRyNhCe8O-d2Ld6oYUkehk4zz1i3CzspOA@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox